Move code ouf of the klippy:ready handler into a deferred callback. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using tmc_mcu without breaking the rules of klippy:ready.
|
@andrewmcgr this looks reasonable, what are your thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the klippy:ready event handler breaks the rules by pausing the reactor. This happens when using mcu_tmc.
As a result of that, the printer will appear ready to Moonraker before it really, which then can lead to Moonraker sending commands to a not-ready Klipper. A scenario where this happens (moonraker-timelapse) and details can be found in the discussion of Klipper3d/klipper#6631.
This fix moves the problematic code out of the event handler by registering a callback which then runs the tuning.