questionAnswers state remains undefined on update

[waheed25]

when i insert data in login filed it shows in the console.log set state questionAnswer arguments but var that is storing questionAnswer remain undefined

key: 'handleAnswerChange',
value: function handleAnswerChange(questionId, questionAnswer) { debugger;
var questionAnswers = _.chain(this.state.questionAnswers).set(questionId, questionAnswer).value();

  this.setState({
    questionAnswers: questionAnswers
  }, this.props.onUpdate.bind(null, questionAnswers));
}

},

when i update questionAnwer it remains undefined but in the lodash function arguments it shows updated value

[waheed25]

[andrewhathaway]

Hi @waheed25.

I'm not entirely sure what is happening here. If you get use the onUpdate prop, is any data getting passed back to those? I'd double check your configuration and ensure everything is ok and valid!

[kascote]

I'm seeing a similar issue when change panels, questionAnswers become undefined. (Not sure if is related to you case @waheed25 , may be)

I traced the issue to this line https://github.com/andrewhathaway/Winterfell/blob/master/src/index.js#L74

The issue seems to be that when componentWillReceiveProps execute, it overwrite questionAnswers with nextProps. That will reset quenstionAnswers to his original value or put undefined if not passed when defined the component.

I fixed it doing:

    this.setState({
        action          : nextProps.action,
        schema          : nextProps.schema,
        questionAnswers : Object.assign({}, nextProps.questionAnswers, this.state.questionAnswers),
    })

this way, questionAnswers is merged with his orignal state and the new values.... I don't see problems so far.

[brunitob]

@kascote works for me!

PR?