Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing wasm-opt errors #2389

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Try fixing wasm-opt errors #2389

merged 3 commits into from
Feb 25, 2025

Conversation

andrewdavidmackenzie
Copy link
Owner

Seems that a new flag is needed

Ref: WebAssembly/wasi-sdk#254

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88%. Comparing base (205497b) to head (34a27b3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
flowc/src/lib/compiler/compile_wasm.rs 97% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2389   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         150     150           
  Lines       18516   18536   +20     
======================================
+ Hits        16171   16181   +10     
- Misses       2345    2355   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie andrewdavidmackenzie merged commit 8a01c38 into master Feb 25, 2025
6 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the fix_wasm_build branch February 25, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant