workspace lints (#2115)

* Small reduction in compile time

* Try workspace lints

Cargo.toml

@@ -40,3 +40,12 @@ ci = ["github"]
 installers = ["shell"]
 # Target platforms to build apps for (Rust target-triple syntax)
 targets = ["x86_64-unknown-linux-gnu", "x86_64-apple-darwin", "aarch64-apple-darwin"]
+
+[workspace.lints.rust]
+unsafe_code = "forbid"
+missing_docs = "deny"
+
+[workspace.lints.clippy]
+unwrap_used = "forbid"
+result_large_err = "allow"
+indexing_slicing = "deny"

flowc/Cargo.toml

@@ -9,6 +9,7 @@ homepage.workspace = true
 repository.workspace = true
 readme = "README.md"
 edition.workspace = true
+lints.workspace = true
 
 [badges]
 maintenance = { status = "actively-developed" }

flowc/src/bin/flowc/main.rs

@@ -1,6 +1,3 @@
-#![deny(missing_docs)]
-#![warn(clippy::unwrap_used)]
-#![allow(clippy::result_large_err)]
 //! `flowc` is a "flow compiler" that takes a hierarchical description of a flow
 //! using [flow definitions][flowcore::model::flow_definition::FlowDefinition],
 //! [function definitions][flowcore::model::function_definition::FunctionDefinition] and
@@ -18,7 +15,7 @@ use std::process::exit;
 
 use clap::{Arg, ArgMatches, Command};
 use env_logger::Builder;
-use log::{debug, error, info, LevelFilter, warn};
+use log::{debug, error, info, LevelFilter};
 use serde_derive::Deserialize;
 use simpath::Simpath;
 use url::Url;

flowcore/Cargo.toml

@@ -9,6 +9,7 @@ homepage.workspace = true
 repository.workspace = true
 readme = "README.md"
 edition.workspace = true
+lints.workspace = true
 
 # Files to exclude from packaging and publishing
 exclude = [".gitignore", "Cargo.lock"]

flowcore/src/lib.rs

@@ -1,6 +1,3 @@
-#![deny(missing_docs)]
-#![warn(clippy::unwrap_used)]
-
 //! `flowcore` defines core structs and traits used by other flow libraries and implementations
 
 use serde_json::Value;

flowmacro/Cargo.toml

@@ -9,6 +9,7 @@ homepage.workspace = true
 repository = "https://github.com/andrewdavidmackenzie/flow/"
 readme = "README.md"
 edition.workspace = true
+lints.workspace = true
 
 [badges]
 maintenance = { status = "actively-developed" }

flowmacro/src/lib.rs

@@ -1,4 +1,3 @@
-#![deny(missing_docs)]
 #![feature(proc_macro_span)]
 //! `flow_function` is a `proc_macro_attribute` macro that wraps a `fn` with a struct and a method
 //! to implement the [Implementation][flowcore::Implementation] trait, so it can be used as the

flowr/Cargo.toml

@@ -9,6 +9,7 @@ homepage.workspace = true
 repository.workspace = true
 readme = "README.md"
 edition.workspace = true
+lints.workspace = true
 
 [badges]
 maintenance = { status = "actively-developed" }

flowr/src/bin/flowrcli/main.rs

@@ -1,5 +1,3 @@
-#![deny(missing_docs)]
-#![forbid(clippy::unwrap_used)]
 //! `flowr` is a command line flow runner for running `flow` programs.
 //!
 //! It reads a compiled [FlowManifest][flowcore::model::flow_manifest::FlowManifest] produced by a

flowr/src/bin/flowrex/main.rs

@@ -1,5 +1,3 @@
-#![deny(missing_docs)]
-#![warn(clippy::unwrap_used)]
 //! `flowrex` is the minimal executor of flow jobs. It loads a native version of 'flowstdlib'
 //! flow library to allow execution of jobs using functions provided by 'flowstdlib', but it does
 //! *not* load 'context' and hence will not execute any jobs interacting with the context.
@@ -16,7 +14,7 @@ use std::sync::Arc;
 
 use clap::{Arg, ArgMatches, Command};
 use env_logger::Builder;
-use log::{error, info, LevelFilter, trace, warn};
+use log::{error, info, LevelFilter, trace};
 use simpath::Simpath;
 use simpdiscoverylib::BeaconListener;
 #[cfg(feature = "flowstdlib")]

flowr/src/bin/flowrgui/main.rs

@@ -1,6 +1,3 @@
-#![warn(clippy::unwrap_used)]
-#![deny(missing_docs)]
-// TODO re-instate #![warn(clippy::unwrap_used)]
 //! `flowrgui` is a GUI flow runner for running `flow` programs.
 //!
 //! It reads a compiled [FlowManifest][flowcore::model::flow_manifest::FlowManifest] produced by a
@@ -38,7 +35,7 @@ use iced::widget::{Button, Column, Row, scrollable, Text, text_input};
 use iced::widget::scrollable::Id;
 use iced_aw::{Card, modal};
 use image::{ImageBuffer, Rgba, RgbaImage};
-use log::{info, LevelFilter, warn};
+use log::{info, LevelFilter};
 use simpath::Simpath;
 use url::Url;
 

flowr/src/lib/lib.rs

@@ -1,6 +1,3 @@
-#![deny(missing_docs)]
-#![deny(clippy::unwrap_used)]
-#![deny(clippy::indexing_slicing)]
 //! `flowrlib` is the runtime library for flow execution. This can be used to produce a flow runner,
 //! such as the `flowr` command line runner.
 //!

flowstdlib/Cargo.toml

@@ -4,13 +4,14 @@ name = "flowstdlib"
 description = "The standard library of functions and flows for 'flow' programs"
 version = "0.142.0"
 authors = ["Andrew Mackenzie <andrew@mackenzie-serres.net>"]
-# Inherit the others that is not parsed by flowc
+# Inherit the other keys that are not parsed by flowc itself
 license.workspace = true
 documentation.workspace = true
 homepage.workspace = true
 repository.workspace = true
 readme = "README.md"
 edition.workspace = true
+lints.workspace = true
 
 [badges]
 maintenance = { status = "actively-developed" }

flowstdlib/src/lib.rs

@@ -1,5 +1,3 @@
-#![deny(missing_docs)]
-#![warn(clippy::unwrap_used)]
 //! `flowstdlib` is a library of flows and functions that can be used from flows.
 //!
 //! The flow and function definition are used at compile time when compile flows that reference