Add test for custom conditions

src/compiler/moduleNameResolver.ts

@@ -1524,7 +1524,7 @@ export function hybridModuleNameResolver(moduleName: string, containingFile: str
     if (getResolveJsonModule(compilerOptions)) {
         extensions |= Extensions.Json;
     }
-    return nodeModuleNameResolverWorker(NodeResolutionFeatures.HybridDefault, moduleName, containingDirectory, compilerOptions, host, cache, extensions, /*isConfigLookup*/ false, redirectedReference);
+    return nodeModuleNameResolverWorker(getNodeResolutionFeatures(compilerOptions), moduleName, containingDirectory, compilerOptions, host, cache, extensions, /*isConfigLookup*/ false, redirectedReference);
 }
 
 export function nodeModuleNameResolver(moduleName: string, containingFile: string, compilerOptions: CompilerOptions, host: ModuleResolutionHost, cache?: ModuleResolutionCache, redirectedReference?: ResolvedProjectReference): ResolvedModuleWithFailedLookupLocations;

src/testRunner/compilerRunner.ts

@@ -163,6 +163,8 @@ class CompilerTest {
         "useUnknownInCatchVariables",
         "noUncheckedIndexedAccess",
         "noPropertyAccessFromIndexSignature",
+        "resolvePackageJsonExports",
+        "resolvePackageJsonImports",
     ];
     private fileName: string;
     private justName: string;

tests/baselines/reference/customConditions(resolvepackagejsonexports=false).js

@@ -0,0 +1,33 @@
+//// [tests/cases/conformance/moduleResolution/customConditions.ts] ////
+
+//// [package.json]
+{
+    "name": "lodash",
+    "version": "1.0.0",
+    "main": "index.js",
+    "exports": {
+        "browser": "./browser.js",
+        "webpack": "./webpack.js",
+        "default": "./index.js"
+    }
+}
+
+//// [index.d.ts]
+declare const _: "index";
+export = _;
+
+//// [browser.d.ts]
+declare const _: "browser";
+export default _;
+
+//// [webpack.d.ts]
+declare const _: "webpack";
+export = _;
+
+//// [index.ts]
+import _ from "lodash";
+
+
+//// [index.js]
+"use strict";
+exports.__esModule = true;

tests/baselines/reference/customConditions(resolvepackagejsonexports=false).symbols

@@ -0,0 +1,25 @@
+=== /node_modules/lodash/index.d.ts ===
+declare const _: "index";
+>_ : Symbol(_, Decl(index.d.ts, 0, 13))
+
+export = _;
+>_ : Symbol(_, Decl(index.d.ts, 0, 13))
+
+=== /node_modules/lodash/browser.d.ts ===
+declare const _: "browser";
+>_ : Symbol(_, Decl(browser.d.ts, 0, 13))
+
+export default _;
+>_ : Symbol(_, Decl(browser.d.ts, 0, 13))
+
+=== /node_modules/lodash/webpack.d.ts ===
+declare const _: "webpack";
+>_ : Symbol(_, Decl(webpack.d.ts, 0, 13))
+
+export = _;
+>_ : Symbol(_, Decl(webpack.d.ts, 0, 13))
+
+=== /index.ts ===
+import _ from "lodash";
+>_ : Symbol(_, Decl(index.ts, 0, 6))
+

tests/baselines/reference/customConditions(resolvepackagejsonexports=false).trace.json

@@ -0,0 +1,22 @@
+[
+    "======== Resolving module 'lodash' from '/index.ts'. ========",
+    "Explicitly specified module resolution kind: 'Hybrid'.",
+    "File '/package.json' does not exist.",
+    "Loading module 'lodash' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration, JSON.",
+    "Found 'package.json' at '/node_modules/lodash/package.json'.",
+    "'package.json' does not have a 'typesVersions' field.",
+    "File '/node_modules/lodash.ts' does not exist.",
+    "File '/node_modules/lodash.tsx' does not exist.",
+    "File '/node_modules/lodash.d.ts' does not exist.",
+    "'package.json' does not have a 'typings' field.",
+    "'package.json' does not have a 'types' field.",
+    "'package.json' has 'main' field 'index.js' that references '/node_modules/lodash/index.js'.",
+    "File '/node_modules/lodash/index.js' does not exist.",
+    "Loading module as file / folder, candidate module location '/node_modules/lodash/index.js', target file types: TypeScript, Declaration.",
+    "File name '/node_modules/lodash/index.js' has a '.js' extension - stripping it.",
+    "File '/node_modules/lodash/index.ts' does not exist.",
+    "File '/node_modules/lodash/index.tsx' does not exist.",
+    "File '/node_modules/lodash/index.d.ts' exist - use it as a name resolution result.",
+    "Resolving real path for '/node_modules/lodash/index.d.ts', result '/node_modules/lodash/index.d.ts'.",
+    "======== Module name 'lodash' was successfully resolved to '/node_modules/lodash/index.d.ts' with Package ID 'lodash/index.d.ts@1.0.0'. ========"
+]

tests/baselines/reference/customConditions(resolvepackagejsonexports=false).types

@@ -0,0 +1,25 @@
+=== /node_modules/lodash/index.d.ts ===
+declare const _: "index";
+>_ : "index"
+
+export = _;
+>_ : "index"
+
+=== /node_modules/lodash/browser.d.ts ===
+declare const _: "browser";
+>_ : "browser"
+
+export default _;
+>_ : "browser"
+
+=== /node_modules/lodash/webpack.d.ts ===
+declare const _: "webpack";
+>_ : "webpack"
+
+export = _;
+>_ : "webpack"
+
+=== /index.ts ===
+import _ from "lodash";
+>_ : "index"
+

tests/baselines/reference/customConditions(resolvepackagejsonexports=true).js

@@ -0,0 +1,33 @@
+//// [tests/cases/conformance/moduleResolution/customConditions.ts] ////
+
+//// [package.json]
+{
+    "name": "lodash",
+    "version": "1.0.0",
+    "main": "index.js",
+    "exports": {
+        "browser": "./browser.js",
+        "webpack": "./webpack.js",
+        "default": "./index.js"
+    }
+}
+
+//// [index.d.ts]
+declare const _: "index";
+export = _;
+
+//// [browser.d.ts]
+declare const _: "browser";
+export default _;
+
+//// [webpack.d.ts]
+declare const _: "webpack";
+export = _;
+
+//// [index.ts]
+import _ from "lodash";
+
+
+//// [index.js]
+"use strict";
+exports.__esModule = true;

tests/baselines/reference/customConditions(resolvepackagejsonexports=true).symbols

@@ -0,0 +1,25 @@
+=== /node_modules/lodash/index.d.ts ===
+declare const _: "index";
+>_ : Symbol(_, Decl(index.d.ts, 0, 13))
+
+export = _;
+>_ : Symbol(_, Decl(index.d.ts, 0, 13))
+
+=== /node_modules/lodash/browser.d.ts ===
+declare const _: "browser";
+>_ : Symbol(_, Decl(browser.d.ts, 0, 13))
+
+export default _;
+>_ : Symbol(_, Decl(browser.d.ts, 0, 13))
+
+=== /node_modules/lodash/webpack.d.ts ===
+declare const _: "webpack";
+>_ : Symbol(_, Decl(webpack.d.ts, 0, 13))
+
+export = _;
+>_ : Symbol(_, Decl(webpack.d.ts, 0, 13))
+
+=== /index.ts ===
+import _ from "lodash";
+>_ : Symbol(_, Decl(index.ts, 0, 6))
+

tests/baselines/reference/customConditions(resolvepackagejsonexports=true).trace.json

@@ -0,0 +1,17 @@
+[
+    "======== Resolving module 'lodash' from '/index.ts'. ========",
+    "Explicitly specified module resolution kind: 'Hybrid'.",
+    "File '/package.json' does not exist.",
+    "Loading module 'lodash' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration, JSON.",
+    "Found 'package.json' at '/node_modules/lodash/package.json'.",
+    "'package.json' does not have a 'typesVersions' field.",
+    "Saw non-matching condition 'browser'.",
+    "Matched 'exports' condition 'webpack'.",
+    "Using 'exports' subpath '.' with target './webpack.js'.",
+    "File name '/node_modules/lodash/webpack.js' has a '.js' extension - stripping it.",
+    "File '/node_modules/lodash/webpack.ts' does not exist.",
+    "File '/node_modules/lodash/webpack.tsx' does not exist.",
+    "File '/node_modules/lodash/webpack.d.ts' exist - use it as a name resolution result.",
+    "Resolving real path for '/node_modules/lodash/webpack.d.ts', result '/node_modules/lodash/webpack.d.ts'.",
+    "======== Module name 'lodash' was successfully resolved to '/node_modules/lodash/webpack.d.ts' with Package ID 'lodash/webpack.d.ts@1.0.0'. ========"
+]

tests/baselines/reference/customConditions(resolvepackagejsonexports=true).types

@@ -0,0 +1,25 @@
+=== /node_modules/lodash/index.d.ts ===
+declare const _: "index";
+>_ : "index"
+
+export = _;
+>_ : "index"
+
+=== /node_modules/lodash/browser.d.ts ===
+declare const _: "browser";
+>_ : "browser"
+
+export default _;
+>_ : "browser"
+
+=== /node_modules/lodash/webpack.d.ts ===
+declare const _: "webpack";
+>_ : "webpack"
+
+export = _;
+>_ : "webpack"
+
+=== /index.ts ===
+import _ from "lodash";
+>_ : "webpack"
+

tests/cases/conformance/moduleResolution/customConditions.ts

@@ -0,0 +1,31 @@
+// @moduleResolution: hybrid
+// @customConditions: webpack, browser
+// @resolvePackageJsonExports: true, false
+// @traceResolution: true
+
+// @Filename: /node_modules/lodash/package.json
+{
+    "name": "lodash",
+    "version": "1.0.0",
+    "main": "index.js",
+    "exports": {
+        "browser": "./browser.js",
+        "webpack": "./webpack.js",
+        "default": "./index.js"
+    }
+}
+
+// @Filename: /node_modules/lodash/index.d.ts
+declare const _: "index";
+export = _;
+
+// @Filename: /node_modules/lodash/browser.d.ts
+declare const _: "browser";
+export default _;
+
+// @Filename: /node_modules/lodash/webpack.d.ts
+declare const _: "webpack";
+export = _;
+
+// @Filename: /index.ts
+import _ from "lodash";