chore: remove unused react-is dependency#167
Open
andrerfneves wants to merge 1 commit into
Open
Conversation
- react-is is listed as a direct dependency but is not imported or used anywhere in the application code - It is already installed transitively via react-qr-code -> prop-types - Removing it reduces the direct dependency surface
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
react-isdependency frompackage.json.Problem
react-isis listed as a direct dependency but is not imported or used anywhere in the application codestyled-components(v5.x), but v6.x no longer requires itreact-qr-code->prop-types->react-is, so removing it from the top-level dependencies is safeVerification
components/andpages/— noreact-isimports foundnpm run buildpasses successfullyImpact
package.jsonandpackage-lock.json