resolved minor issue from response of post

andreoug · May 18, 2018 · a3b8a8d · a3b8a8d
1 parent 8470c3a
commit a3b8a8d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/shorty/src/main/java/com/neueda/shorty/controller/UrlController.java b/shorty/src/main/java/com/neueda/shorty/controller/UrlController.java
@@ -41,7 +41,7 @@ public class UrlController {
 
         String shortUrl = urlService.addUrl(longUrl);
         if(shortUrl != null)
-            return shortUrl;
+            return RESOURCE_URI + "/" + shortUrl;
 
         return ErrorMessage.BAD_REQUEST_EMPTY_URL.getMessage();
     }

diff --git a/shorty/src/test/java/com/neueda/shorty/controller/UrlControllerTest.java b/shorty/src/test/java/com/neueda/shorty/controller/UrlControllerTest.java
@@ -87,9 +87,7 @@ public void test__postUrl() throws Exception{
                         .content(longUrl))
                 .andExpect(status().isOk())
                 .andExpect(content().contentType("text/plain;charset=ISO-8859-1"))
-                //fixme-allemaos: this TEST_RESOURCE_URI shouldn't be empty
-//                .andExpect(content().string(TEST_RESOURCE_URI+"/"+shortUrl))
-                .andExpect(content().string(shortUrl))
+                .andExpect(content().string(TEST_RESOURCE_URI+"/"+shortUrl))
                 .andDo(print());
     }