Skip to content

Commit

Permalink
Merge pull request roidrage#235 from maschwenk/chore-no-upper-limit-d…
Browse files Browse the repository at this point in the history
…ependency

No upper bound dependencies on AS/AP/Railties
  • Loading branch information
benlovell authored Jan 12, 2018
2 parents a04b362 + f6e3bae commit 2ef2d9e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ gemspec
gem 'pry', group: :development

group :test do
gem 'actionpack', '~> 5.1.1'
gem 'activerecord', '~> 5.1.1'
gem 'actionpack', '~> 5'
gem 'activerecord', '~> 5'
# logstash does not release any gems on rubygems, but they have two gemspecs within their repo.
# Using the tag is an attempt of having a stable version to test against where we can ensure that
# we test against the correct code.
Expand Down
6 changes: 3 additions & 3 deletions lograge.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rspec'
s.add_development_dependency 'rubocop', '0.46.0'

s.add_runtime_dependency 'activesupport', '>= 4', '< 5.2'
s.add_runtime_dependency 'actionpack', '>= 4', '< 5.2'
s.add_runtime_dependency 'railties', '>= 4', '< 5.2'
s.add_runtime_dependency 'activesupport', '>= 4'
s.add_runtime_dependency 'actionpack', '>= 4'
s.add_runtime_dependency 'railties', '>= 4'
s.add_runtime_dependency 'request_store', '~> 1.0'
end

0 comments on commit 2ef2d9e

Please sign in to comment.