Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow restriction of resources by IP #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rawbertp
Copy link
Contributor

@rawbertp rawbertp commented Nov 5, 2019

Restrict certain configurable IP addresses to the gallery only. This feature can be turned on/off.

Restrictions:

  • Unauthorized access to /admin/index.php gets denied.
  • Access to /index.php gets redirected to /gallery.php.

TODO (hints appreciated):

  • Make the security_privileged_ips array editable in the admin area (the input fields are already shown but I need some JS to dynamically add/remove fields - if anyone has a good re-usable example, please let me know)
  • Also support IP ranges/wildcards?
  • Better naming
  • Optional: There could be another (optional) list guest_ips to also restrict access to the gallery. If not set, everyone has access.

This addresses #182

@andi34
Copy link
Collaborator

andi34 commented Dec 16, 2019

Can't we save the IPs inside a
Txt file inside /data and load it's content as an input value?

@andi34
Copy link
Collaborator

andi34 commented Dec 17, 2019

Similar to https://github.com/andreknieriem/photobooth/blob/master/lib/db.php maybe to add or remove an IP and https://github.com/andreknieriem/photobooth/blob/master/index.php#L7 to show them as input config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants