Feature request collection #68

andi34 · 2019-09-09T13:26:55Z

Please use this "issue" for feature requests. Starting post will be updated with your suggestions.

Feature added

Ready for review

Work in progress (WIP)

Main Css Styling in Admin Panel (Feature request: Main Css Styling in Admin Panel #104)

Help wanted

take 10 second videos/gifs (Feature request: Take 10 second videos #35)

Declined

Camera profiles with predefined config (Feature request: Camera profiles and switching between them #99)
button for shutdown or restart in admin- or user-page ( Feature request: Sytembutton Admin-/ Userpage to shutdown or restart the system #100 )

thymon13 · 2019-09-09T15:38:12Z

Button on gallery

The buttons on the photos from the gallery are too small and especially unsightly.

Would it be possible to enlarge them?
It would be best to have them in the middle of the picture.
CSS buttons that appear and disappears when click on the photo. ?

like this for exemple :

thymon13 · 2019-09-09T15:44:41Z

QR Code Pop'up not resized

I use a 9.6" touche pad. And the QR code is truncated.
I'have try with "false" ou "true" in my config for enable or not the mobile view.
No change.

andi34 · 2019-09-09T15:53:49Z

QR Code Pop'up not resized

I use a 9.6" touche pad. And the QR code is truncated.
I'have try with "false" ou "true" in my config for enable or not the mobile view.
No change.

@thymon13 belongs here #22

Bouton on gallery

The buttons on the photos from the gallery are too small and especially unsightly.

Would it be possible to enlarge them?
It would be best to have them in the middle of the picture.
CSS buttons that appear and disappears when click on the photo. ?

(...)

This is also a design thing and not a feature itself.

thymon13 · 2019-09-09T18:25:00Z

Chroma Keying

I tested this function. Thats work perfectly.
But is it possible to use one picture background by default ? Instead of choose them in gallery -> select photo -> select function --> select background...

Example : Corporation event with Enterprise Logo in background by default...

andi34 · 2019-09-09T19:01:09Z

Chroma Keying

I tested this function. Thats work perfectly.
But is it possible to use one picture background by default ? Instead of choose them in gallery -> select photo -> select function --> select background...

Example : Corporation event with Enterprise Logo in background by default...

You can adjust the source for your needs https://github.com/andreknieriem/photobooth/blob/master/chroma_keying/index.php#L51

thymon13 · 2019-09-09T19:14:42Z

This is also a design thing and not a feature itself.

@andi34 really ? 😭 😭
So I open a design issue ? 😆😆

thymon13 · 2019-09-09T19:21:46Z

I found anothers errors for french translation...

thymon13 · 2019-09-09T19:36:00Z

you can adjust the source for your needs
#68 (comment)

I think my question is not clear. When you take a picture the result is with the green background. and you have to go to the gallery to choose the background you want to incorporate. While it would be nice to have the result directly when the picture is taken.

andi34 · 2019-09-09T19:38:05Z

That's nothing I am going to make an option. You can take a look at the chroma_keying source and modify the takePic.php for it, or use the new frame function (can also be added to takePic.php to apply the frame directly).

andi34 · 2019-09-09T19:42:08Z

This is also a design thing and not a feature itself.

@andi34 really ?
So I open a design issue ?

Could also be part of the responsive design.
I am not able to implement every feature request myself (I've a full time job as a medical assistant and still learning js, php etc). Everyone is welcome to adjust the source for his/her needs and send a Pullrequest with useful changes (sure, I can make it clean commits in the end as I have a lot of experience with git).

I am going to write a quick "how to submit code changes" soon.

andi34 · 2019-09-09T19:43:44Z

I found anothers errors for french translation...

Fork latest source, update the language file on your git fork and send me a link for it. Maybe there's more to be adjusted?

thymon13 · 2019-09-09T19:44:25Z

Ok thank you Andi34 for your answer.

Fork latest source, update the language file on your git fork and send me a link for it. Maybe there's more to be adjusted?

yes exactly more corrections

andi34 · 2019-09-09T19:47:31Z

@thymon13 maybe useful for you until ready:

git fetch https://github.com/andi34/photobooth private
git cherry-pick d317f58d95752ac585c8e2545ef24957ceb11a4c
git cherry-pick 9dab3dfae43342952ba5f6db85c5123aa3869c0b
git cherry-pick 250172ae175e6f815375335dcce566b840ad7bb2

thymon13 · 2019-09-09T20:35:41Z

news private fetch for what ?

and how you commit ?

git cherry-pick d317f58d95752ac585c8e2545ef24957ceb11a4c
error: Your local changes to the following files would be overwritten by merge:
	resources/css/style.css
	resources/js/core.js
	resources/sass/style.scss
Please commit your changes or stash them before you merge.
Aborting
fatal: cherry-pick failed

git add --all && git commit -a ???

andi34 · 2019-09-09T20:46:49Z

This would create a commit with your made changes, yes. After that you can cherry-pick

thymon13 · 2019-09-09T20:54:24Z

@andi34
I'm really sorry but I do not understand anything

git cherry-pick d317f58d95752ac585c8e2545ef24957ceb11a4c
error: your local changes would be overwritten by cherry-pick.
hint: commit your changes or stash them to proceed.
fatal: cherry-pick failed

andi34 · 2019-09-10T05:16:34Z

git cherry-pick --abort
git add --all
git commit -a -m "My local changes"
git format-patch -1

After that it should work. You'll only have conflicts at cherry-pick if you've modified the source at the same places already.
With git format-patch we create a patch file from your changes so you can apply them easy again in future. Keep the patch file at a safe place.

thymon13 · 2019-09-10T18:54:29Z

@andi34 ok it's done

andi34 · 2019-09-10T19:50:54Z

Maybe the adjustments for smaller device helps you a little bit

thymon13 · 2019-09-10T20:29:48Z

Well no... 😢

look : https://youtu.be/J8yeS-4Nu7s

andi34 · 2019-09-11T04:28:28Z

What's your resolution?
You could try to adjust the @media (max-width: 800px) inside the style.css

thymon13 · 2019-09-11T10:14:31Z

1280x800px
I will test it, thx

andi34 · 2019-09-16T13:00:16Z

@msmedien gerade erst gerallt das du auch eine Implementierung hast 🤗
Diese Teste ich natürlich auch, finde die Idee gut auf externe Scripts zu verzichten wie es bei dir der Fall ist.

andi34 · 2019-09-16T16:47:49Z

@msmedien I've pushed your changes here for now. I'll make it one clean commit and do some adjustments within this week. https://github.com/andi34/photobooth/commits/dev

andi34 · 2019-09-16T17:29:48Z

Ready for review

print confirmation ( @flighter18 , @msmedien ):
andi34@3272cb7
andi34@bc3daf1

To test this changes:
Make sure your local clone does ignore filemode changes:

cd /var/www/html
git config core.fileMode false
sudo git config core.fileMode false

Now add my Github copy as remote and fetch the source:

git remote add andi34 https://github.com/andi34/photobooth
git fetch andi34

Make sure you have no local changes which will be lost, if you have you need to commit them. Best ist to keep them in a seperate branch you can go back to later:

git add --all
git commit -a -m "All my local changes"
git checkout -b myBackupBranch

Now switch to my source:

git checkout andi34/dev

Happy testing!

In case you need to switch back to your local source you only need to checkout to your backup branch which we've created before.

git checkout myBackupBranch

Questions? Let me know!

Please leave some feedback if the print confirmation works for you as expected. Quickly tested and seems to be fine.
Translation wrong/need adjustment? Let me know too before i merge the changes here!

andi34 · 2019-09-16T20:12:53Z

would it be possible to use PiCamera for Preview and Photo ?

looking at apache error logs it seems that when using the PiCamera for Preview it cannot be accessed in the command line to take Photo and therefore and error happens.

Would it be possible to stop the Preview just before the Photo function to take the photo is called?

Could you try to move this parts up a little bit?

photobooth/resources/js/core.js

Lines 123 to 127 in 84b3c21

    
           if(useVideo){ 
        
               var track = public.stream.getTracks()[0]; 
        
               track.stop(); 
        
               $('video').hide(); 
        
           }

So it looks like:

    // take Picture
    public.takePic = function (photoStyle) {
        processing = true;
        if (isdev) {
            console.log('Take Picture:' + photoStyle);
        }
        if(useVideo){
            var track = public.stream.getTracks()[0];
            track.stop();
            $('video').hide();
        }
        setTimeout(function () {
	    if ((photoStyle=='photo')){
                $('#counter').text('');
                $('.spinner').show();
                $('.loading').text(L10N.busy);
            } else {

thymon13 · 2019-09-17T20:58:39Z

@andi34
Nice Tutorial ! Need to add this en (FAQ)

I tested "Print Confirmation" Soooooo great ! Works perfectly

andi34 · 2019-09-18T15:45:18Z

Feature added

print confirmation ( @flighter18 , @msmedien )

Merged 😃
ab2ebf3
58fb383

Thanks everyone 👍

andi34 · 2019-09-18T18:19:43Z

Ready for review

polaroid effect: andi34@df3b84d

Might need adjustment to also use $filename_orig = $filename_tmp;

If you have trouble to not have the effect applied:
Inside takePic.php change from

if($_POST['style'] === 'photo') {
	$filename_orig = $filename_photo;
	$use_filter = false;
} else {
	$filename_orig = $filename_tmp;
	$use_filter = false;
}
if(!empty($_POST) && !($_POST['filter'] === 'imgPlain')) {
	$filename_orig = $filename_tmp;
	$use_filter = true;
	$imgfilter = $_POST['filter'];
}

to

if(($_POST['style'] === 'photo') && !($config['polaroid_effect'])){
	$filename_orig = $filename_photo;
	$use_filter = false;
} else {
	$filename_orig = $filename_tmp;
	$use_filter = false;
}

if(!empty($_POST) && !($_POST['filter'] === 'imgPlain')) {
	$filename_orig = $filename_tmp;
	$use_filter = true;
	$imgfilter = $_POST['filter'];
}

Examples:

andi34 · 2019-09-18T18:42:19Z

Btw. You can follow the steps mentioned here again to test this new feature:
#68 (comment)

If you've already added my fork as remote you only need to run

cd /var/www/html
git fetch andi34
git checkout andi34/dev

vdubuk · 2019-09-19T06:39:59Z

Could you try to move this parts up a little bit?

photobooth/resources/js/core.js

Lines 123 to 127 in 84b3c21

    
           if(useVideo){ 
        
               var track = public.stream.getTracks()[0]; 
        
               track.stop(); 
        
               $('video').hide(); 
        
           }

So it looks like:

    // take Picture
    public.takePic = function (photoStyle) {
        processing = true;
        if (isdev) {
            console.log('Take Picture:' + photoStyle);
        }
        if(useVideo){
            var track = public.stream.getTracks()[0];
            track.stop();
            $('video').hide();
        }
        setTimeout(function () {
	    if ((photoStyle=='photo')){
                $('#counter').text('');
                $('.spinner').show();
                $('.loading').text(L10N.busy);
            } else {

This solution worked for me, thank you @andi34

andi34 · 2019-09-19T08:30:55Z

Thanks for the feedback @vdubuk .
@andreknieriem it's fine to submit the code change or it's a wanted behavior to stop the preview at the point it is?

Edit:
Change:andi34@e37c7ec

andreknieriem · 2019-09-19T08:36:42Z

Can be changed ;)

vdubuk · 2019-09-19T10:47:21Z

Kiosk Mode feature request

When running app in Kiosk mode it can be difficult to get to the Admin/settings page.

therefore I would like to suggest of having a hidden shortcut to get to settings - to prevent accidental / unauthorised access you need to double click the bottom right location 4 times. This can be changed in adminshortcut.js if (admincount == 3) {

index.php around line 274 after the print mesg div

        
	<!-- added div --> 

	<div id="adminsettings" >
		<div style="position:absolute; bottom:0; right:0;"><img src="/resources/img/spacer.png" 
        alt="adminsettings" ondblclick="adminsettings()"></div>
	</div>  
 
	<script type="text/javascript" src="/resources/js/adminshortcut.js"></script> 

	<!-- end -->

	
     
```
create new file aresources/js/adminshortcut.js 

```
var admincount = 0;
		function countreset() {
			admincount = 0;
		}
		function adminsettings() {
			if (admincount == 3) {
				window.location.href="admin/index.php";
			}
			console.log(admincount);
			admincount++;
			setTimeout(countreset, 10000);
		}

```

add spacer.png to resources/img/ 

![spacer](https://user-images.githubusercontent.com/4080228/65237830-51646780-dad3-11e9-8adb-0293086f88fb.png)

This allows to use Pi Camera for preview and for taking pictures. Fixes the following Issue: #68 (comment) #68 (comment)

When running app in Kiosk mode it can be difficult to get to the Admin/settings page. Issue/Feature request: andreknieriem#68 (comment)

andi34 · 2019-09-19T11:23:59Z

Kiosk Mode feature request

When running app in Kiosk mode it can be difficult to get to the Admin/settings page.

therefore I would like to suggest of having a hidden shortcut to get to settings
....

works fine on my end. ready for testing in my dev branch.

andi34 · 2019-09-19T17:34:48Z

Doubleclick in the right bottom corner until the admin page appears (for me it takes 4 double clicks in chrome)

When running app in Kiosk mode it can be difficult to get to the Admin/settings page. Issue/Feature request: #68 (comment)

andi34 · 2019-09-20T08:58:43Z

andi34@6b926f8

Jemand eine Idee?

andi34 · 2019-09-20T11:09:37Z

Found the issue. config.json is ignored... Config.inc.php/my.config.inc.php is used only.
Need to find out how to solve it.
Maybe someone can help?

andi34 · 2019-09-20T12:25:45Z

Found a solution. Moved the php files out of the chroma_keying folder:
f607a41

sualko · 2019-10-06T09:14:15Z

What is the purpose of this issue? Github provides already a nice overview 😉 : enhancement

andi34 · 2019-10-06T09:40:29Z

Purpose was to have one thread/issue for feature request instead having 100 "issues"

sualko · 2019-10-06T09:55:27Z

The advantage of having 100 issues is, that you can reference them inside of issues, pull requests and commits. You have a clear history of an issue, can subscribe to the further development and you can discuss details. But both ways are applicable.

msmedien · 2019-10-08T10:24:49Z

Da das Green-Screen-Feature jetzt läuft, frage ich mich jedoch ob es nicht einen benutzerfreundlicheren Weg gibt dieses zu bedienen...

Auf der Startseite den "Foto erstellen"-Button drücken
Countdown + Foto wird erstellt
Foto wird angezeigt inkl. der Auswahl der verschiedenen Hintergründen (ähnlich wie über die Gallerie-Funktion nur ohne "Drucken"- und "Schließen"-Button)
Hintergrund wählen und speichern (oder ein "Weiter"-Button)
Anzeige des fertigen Fotos inkl. der "normalen" Buttons (wie z.B. Gallerie, QR-Code, Neues Fotos etc. pp - So wie es jetzt auch ist nachdem das normale Foto geschossen wurde)

Natürlich nur wenn das Green-Screen-Feature aktiviert ist, ansonsten sollte über den Button ein ganz normales Foto gemacht werden. - Ggf. auch mit einem extra Button, wie bei der Collagen-Funktion.

andi34 · 2019-10-11T16:47:14Z

Closing this thread as new feature request issues get opened instead posting requests here.
Use own issues which can be closed via Pullrequest if a feature is added.

andi34 added enhancement help wanted labels Sep 18, 2019

andi34 added a commit that referenced this issue Sep 19, 2019

Stop preview earlier

5b8e123

This allows to use Pi Camera for preview and for taking pictures. Fixes the following Issue: #68 (comment) #68 (comment)

andi34 pushed a commit to andi34/photobooth that referenced this issue Sep 19, 2019

Add a hidden shortcut for admin settings

2be2061

When running app in Kiosk mode it can be difficult to get to the Admin/settings page. Issue/Feature request: andreknieriem#68 (comment)

andi34 pushed a commit that referenced this issue Sep 19, 2019

Add a hidden shortcut for admin settings

ab6cc50

When running app in Kiosk mode it can be difficult to get to the Admin/settings page. Issue/Feature request: #68 (comment)

This was referenced Sep 27, 2019

Feature request: Resizing image for printing #82

Closed

responsive layout #78

Merged

andi34 closed this as completed Oct 11, 2019

Feature request collection #68

Feature request collection #68

Comments

andi34 commented Sep 9, 2019 • edited Loading

Please use this "issue" for feature requests. Starting post will be updated with your suggestions.

thymon13 commented Sep 9, 2019 • edited by andi34 Loading

Button on gallery

thymon13 commented Sep 9, 2019

QR Code Pop'up not resized

andi34 commented Sep 9, 2019 • edited Loading

QR Code Pop'up not resized

Bouton on gallery

thymon13 commented Sep 9, 2019 • edited Loading

Chroma Keying

andi34 commented Sep 9, 2019

Chroma Keying

thymon13 commented Sep 9, 2019 • edited Loading

thymon13 commented Sep 9, 2019 • edited Loading

thymon13 commented Sep 9, 2019

andi34 commented Sep 9, 2019

andi34 commented Sep 9, 2019 • edited Loading

andi34 commented Sep 9, 2019 • edited Loading

thymon13 commented Sep 9, 2019 • edited Loading

andi34 commented Sep 9, 2019

thymon13 commented Sep 9, 2019 • edited Loading

andi34 commented Sep 9, 2019

thymon13 commented Sep 9, 2019

andi34 commented Sep 10, 2019 • edited Loading

thymon13 commented Sep 10, 2019

andi34 commented Sep 10, 2019

thymon13 commented Sep 10, 2019

andi34 commented Sep 11, 2019

thymon13 commented Sep 11, 2019

andi34 commented Sep 16, 2019

andi34 commented Sep 16, 2019 • edited Loading

andi34 commented Sep 16, 2019 • edited Loading

andi34 commented Sep 16, 2019 • edited Loading

thymon13 commented Sep 17, 2019 • edited Loading

andi34 commented Sep 18, 2019

andi34 commented Sep 18, 2019 • edited Loading

andi34 commented Sep 18, 2019 • edited Loading

vdubuk commented Sep 19, 2019

andi34 commented Sep 19, 2019 • edited Loading

andreknieriem commented Sep 19, 2019

vdubuk commented Sep 19, 2019 • edited Loading

andi34 commented Sep 19, 2019 • edited Loading

andi34 commented Sep 19, 2019 • edited Loading

andi34 commented Sep 20, 2019

andi34 commented Sep 20, 2019

andi34 commented Sep 20, 2019

sualko commented Oct 6, 2019

andi34 commented Oct 6, 2019

sualko commented Oct 6, 2019

msmedien commented Oct 8, 2019

andi34 commented Oct 11, 2019

andi34 commented Sep 9, 2019 •

edited

Loading

thymon13 commented Sep 9, 2019 •

edited by andi34

Loading

andi34 commented Sep 9, 2019 •

edited

Loading

thymon13 commented Sep 9, 2019 •

edited

Loading

thymon13 commented Sep 9, 2019 •

edited

Loading

thymon13 commented Sep 9, 2019 •

edited

Loading

andi34 commented Sep 9, 2019 •

edited

Loading

andi34 commented Sep 9, 2019 •

edited

Loading

thymon13 commented Sep 9, 2019 •

edited

Loading

thymon13 commented Sep 9, 2019 •

edited

Loading

andi34 commented Sep 10, 2019 •

edited

Loading

andi34 commented Sep 16, 2019 •

edited

Loading

andi34 commented Sep 16, 2019 •

edited

Loading

andi34 commented Sep 16, 2019 •

edited

Loading

thymon13 commented Sep 17, 2019 •

edited

Loading

andi34 commented Sep 18, 2019 •

edited

Loading

andi34 commented Sep 18, 2019 •

edited

Loading

andi34 commented Sep 19, 2019 •

edited

Loading

vdubuk commented Sep 19, 2019 •

edited

Loading

andi34 commented Sep 19, 2019 •

edited

Loading

andi34 commented Sep 19, 2019 •

edited

Loading