updated return statement#2
Merged
Merged
Conversation
andreitoma8
reviewed
Aug 18, 2023
| return(0x80, 0xc0) | ||
| // return the data from slot 0x80 and 0x40 is size of the return data | ||
| return(0x80, 0x40) | ||
| // return(0x80, 0xc0) // returns data of size 0xc0 (which is bigger than expected) |
Owner
There was a problem hiding this comment.
You can delete this line altogether.
andreitoma8
approved these changes
Aug 18, 2023
Owner
andreitoma8
left a comment
andreitoma8
left a comment
There was a problem hiding this comment.
Nice catch, thanks for the contribution!
andreitoma8
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the statement about assembly return second parameter (size)