Update routes.py #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| cursor.execute( | ||
| "SELECT * FROM books WHERE name LIKE %s", | ||
| ("%" + name + "%",) | ||
| "SELECT * FROM books WHERE name LIKE '%" + name + "%'" |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the issue, the SQL query on line 16 should be rewritten to use parameterized queries instead of string concatenation. Parameterized queries ensure that user input is properly escaped and prevent SQL injection attacks. Specifically:
- Replace the concatenation of
nameinto the query string with a placeholder (%s). - Pass the user-provided value (
name) as a parameter to thecursor.executemethod, ensuring it is safely escaped.
This change will align the code with the secure practices demonstrated in the example provided in the background section.
Suggested changeset
1
server/routes.py
| @@ -15,3 +15,4 @@ | ||
| cursor.execute( | ||
| "SELECT * FROM books WHERE name LIKE '%" + name + "%'" | ||
| "SELECT * FROM books WHERE name LIKE %s", | ||
| ("%" + name + "%",) | ||
| ) |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.