added continue-on-errors option for use in specific cases such as end… #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…points with errors or incompatibility in legacy projects
jmgoncalves97
force-pushed
the
add-continue-on-errors-option
branch
from
79e7ad1 to
0f01fc7
Compare
andreaselia
reviewed
Nov 13, 2023
Owner
|
Thanks for your PR @jmgoncalves97, and I appreciate you adding a test case too. Just left a small comment, but the rest looks good to me. cc @tomirons |
Contributor
Author
|
I'm happy to be able to contribute, @andreaselia ! |
Owner
|
@jmgoncalves97 do you by chance have any ideas on what could be causing a test to fail? |
Owner
|
@jmgoncalves97 bit of a merge conflict based on changes, do you mind taking a look at that and the failing test please? If not I'll take a look the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…points with errors or incompatibility in legacy projects