Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change anchor links to use the history API if the router doesn't have a match #18

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+201 −39
Open

Don't change anchor links to use the history API if the router doesn't have a match #18

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1def453
Add support for bypassing router for unhandled links
jbuckner Jan 15, 2021
9f5b467
Cleanup AnchorHandler and add tests
jbuckner Jan 16, 2021
e9fb5b0
Handle metaKey case
jbuckner Jan 16, 2021
ce23bcb
Update comment
jbuckner Jan 16, 2021
5477d86
Small reorganize and add comment
jbuckner Jan 16, 2021
957008f
Add test for catch-all and fix anchor tests
jbuckner Jan 16, 2021
578e748
Rename var for brevity
jbuckner Jan 16, 2021
91b76bb
Update Readme
jbuckner Jan 16, 2021
6387a45
Fix the anchor event handler removal and add test
jbuckner Jan 17, 2021
b8acb91
Only bind the AnchorHandler in the root router-slot
jbuckner Jan 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Readme
  • Loading branch information
@jbuckner
jbuckner committed Jan 16, 2021
commit 91b76bbf31707741a399b3ed1cb8ceaf1ec2aef0
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Go [`here`](https://developer.mozilla.org/en-US/docs/Web/API/History) to read mo

#### Anchor element

Normally an [`anchor element`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a) reloads the page when clicked. This library however changes the default behavior of all anchor element to use the history API instead.
Normally an [`anchor element`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a) reloads the page when clicked. This library however changes the default behavior of all anchor element to use the history API if the router supports the route.

```html
<a href="/home">Go to home!</a>
Expand Down