Be explicit about sugar.lift parameter being typed instead of untyped
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Nim's current overloading system, since `lift` has an overload with the first parameter having a type, the first parameter of any `lift` call is assumed to be typed (which is not preferable, discussion about it [here](nim-lang/RFCs#402)). `lift` currently breaks if this behavior is changed, unless we explicitly write `typed`, so do this in case this gets changed.
|
Feel free to add this patch yourself |
andreaferretti
added a commit
that referenced
this pull request
Apr 24, 2023
|
Sorry it took a while, I applied the change manually as you suggested. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Nim's current overloading system, since
lifthas an overload with the first parameter having a type, the first parameter of anyliftcall is assumed to be typed (which is not preferable, discussion about it here).liftcurrently breaks if this behavior is changed, unless we explicitly writetyped, so do this in case this gets changed.