Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for subtotal issue #813 #896

Closed
wants to merge 1 commit into from

Conversation

DHMike57
Copy link

@DHMike57 DHMike57 commented Oct 5, 2024

issue #813

It seems that the @SUM(r1,r2) is being inserted by the parser in the correct place via sent_to_interp but just sits there unevaluated with result 0. valueize_area then makes the 0 permanent.

This is probably a sticking plaster fix rather than the underlying problem, since I cannot see how the commit that you quoted would have caused this, but at least it gets it working again.

@andmarti1424
Copy link
Owner

Thank you for your patch. Will check it out.

@andmarti1424
Copy link
Owner

@DHMike57 Can confirm the fix. Will merge soon. Thank you.

@andmarti1424
Copy link
Owner

@DHMike57 Merged to dev branch. Thank you!

@DHMike57 DHMike57 deleted the subtotal-quick-fix branch October 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants