Include string.h where needed #830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ uname -a SunOS hipster 5.11 illumos-9ffcdb10b6 i86pc i386 i86pc $ gcc --version gcc (OpenIndiana 10.5.0-oi-0) 10.5.0 ... $ gmake 2>&1 | grep "implicit declaration" file.c:199:10: warning: implicit declaration of function 'strcasecmp' [-Wimplicit-function-declaration] file.c:249:16: warning: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] file.c:249:16: warning: incompatible implicit declaration of built-in function 'strlen' file.c:266:28: warning: incompatible implicit declaration of built-in function 'strlen' file.c:271:31: warning: incompatible implicit declaration of built-in function 'strlen' file.c:283:9: warning: implicit declaration of function 'strcpy' [-Wimplicit-function-declaration] file.c:283:9: warning: incompatible implicit declaration of built-in function 'strcpy' file.c:288:27: warning: incompatible implicit declaration of built-in function 'strlen' file.c:291:16: warning: incompatible implicit declaration of built-in function 'strlen' file.c:358:12: warning: incompatible implicit declaration of built-in function 'strcpy' file.c:529:52: warning: incompatible implicit declaration of built-in function 'strlen' file.c:532:52: warning: incompatible implicit declaration of built-in function 'strlen' file.c:536:74: warning: incompatible implicit declaration of built-in function 'strlen' file.c:537:74: warning: incompatible implicit declaration of built-in function 'strlen' file.c:538:74: warning: incompatible implicit declaration of built-in function 'strlen' file.c:539:74: warning: incompatible implicit declaration of built-in function 'strlen' file.c:540:74: warning: incompatible implicit declaration of built-in function 'strlen' file.c:541:74: warning: incompatible implicit declaration of built-in function 'strlen' ...
|
Here's the full set of "implicit declaration" warnings: implicit-declarations.txt |
|
@sjmulder merged. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up before and fizzled out but unfortunately
it is not:
Not including string.h in these files may happen to work on one platform or another because other headers happen to include it, but that shouldn't be relied on - if functions from a certain header are used, the header should be included.