Skip to content

Conversation

earthshrink
Copy link

@earthshrink earthshrink commented Apr 26, 2020

Adds command gf to open URL or filename given in a cell. Invokes an included script scopen, so it can be customised by installation and overloaded in user's PATH. Command blocks on the script, so the script has the option to run a text mode browser like w3m or editor like vim in foreground, or return after launching a graphics mode browser like firefox or editor like gvim in background. Addresses issue #400.

Document file updated to also note exception to gab24 (Issue #399)

@andmarti1424
Copy link
Owner

May be with the 'G' in uppercase to not collide with 'g' command..

@earthshrink
Copy link
Author

I like the 'G' idea. Maybe we should also fix gg and gl for the same reason, viz that they prevent goto to columns g and l, respectively.

@andmarti1424
Copy link
Owner

Actually yes! You're right.

@andmarti1424
Copy link
Owner

@earthshrink actually 'G' collides as well. 'gt' may be the better option for goto cell..
btw, why you removed the line
sstderr = newterm(NULL, stderr, stdin);
?

@andmarti1424
Copy link
Owner

'g' command of NORMAL_MODE changed to 'gt'"

@earthshrink
Copy link
Author

Re stderr, something was breaking at the time but seems no longer the case after rebasing to freeze tip. I didn't change 'gf' since you fixed the goto to 'gt'. thanks.

@andmarti1424
Copy link
Owner

Will merge this soon, but doc file and Makefile seems outdated.

@andmarti1424
Copy link
Owner

Already merged! Had to make some changes regarding conf since that changed a little. Thank you @earthshrink

@earthshrink
Copy link
Author

earthshrink commented Apr 6, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants