Skip to content

[DO NOT MERGE] fixes from melonDS #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
msink wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] fixes from melonDS #374

msink wants to merge 3 commits into from

Conversation

@msink
Copy link
Contributor

@msink msink commented May 30, 2018 •
edited
Loading

Patches currently applied to libui in melonDS
Maybe something from this should be applied to libui master?

@msink msink mentioned this pull request May 30, 2018
Open
mischnic
mischnic reviewed May 30, 2018
View reviewed changes
darwin/stddialogs.m Outdated
}

char *uiOpenFile(uiWindow *parent)
char *uiOpenFile(uiWindow *parent, char* filter)
Copy link
Contributor

@mischnic mischnic May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter isn't implemented for macOS

@mischnic
Copy link
Contributor

mischnic commented May 30, 2018 •
edited
Loading

Maybe this should get split?

fix drawmatrix transform order to match Windows. fixes rotation.

Is that #331? Then macOS is wrong as well.

add support for non-resizable windows

#316 has macOS support (as a setter and not a constructor argument)

@andlabs
Copy link
Owner

andlabs commented May 30, 2018 •
edited
Loading

Yes; please split this. This does way too many things, some of which I would need to approve the design of, and others which won't work with the upcoming stuff... Let's handle everything one at a time.

@msink
Copy link
Contributor Author

msink commented May 30, 2018 •
edited
Loading

This is not my patches, I just cleaned and sorted them, no functional changes from me.
Anyway this cannot be merged "as-is" - in particular, support for OSX totally missed, melonDS does not work on Mac.

So what should I split?
Make 15 pull requests? Or some are definitely wrong and dont worth cleaning?

@andlabs
Copy link
Owner

andlabs commented May 30, 2018 •
edited
Loading

Are the 15 commits entirely different in scope? If so, then yeah; sorry ^^; If not, we can combine those that aren't into larger PRs.

And don't worry about OS X support; I can take care of that.

Also out of curiosity do you work on melonDS as well?

@msink
Copy link
Contributor Author

msink commented May 31, 2018 •
edited
Loading

Ok, lets go step by step: #375 melonDS dialogs

Also out of curiosity do you work on melonDS as well?

No, no relations.
So I do not want to make any functional changes, only formatting.

@msink
Copy link
Contributor Author

msink commented Jun 1, 2018

Well, splitted to 7 separate PRs.
Something remained here - I doubt it's applicable directly.

@andlabs andlabs added this to the Post-Alpha 5 milestone Dec 31, 2018
@cody271 cody271 mentioned this pull request Jan 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mischnic mischnic mischnic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Post-Alpha 5

Development

Successfully merging this pull request may close these issues.

4 participants

@msink @mischnic @andlabs @Arisotura