This repository was archived by the owner on Jan 17, 2024. It is now read-only.
feat: add AsyncReplyFunc #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katallaxie
reviewed
Nov 11, 2019
|
|
||
| // asyncHandleMessage is a helper used to | ||
| func (p *Plugin) asyncHandleMessage(c Context, fn SubscribeFunc) { | ||
| p.run(func() error { |
There was a problem hiding this comment.
This will exit the exec for the whole plugin upon an error. Is this what u intended?
There was a problem hiding this comment.
Left a comment here to provide more clarity
andrewloux
force-pushed
the
add-async-reply
branch
from
51c6888 to
741b81b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable plugin authors to handle messages concurrently