This repository was archived by the owner on Jan 17, 2024. It is now read-only.
vendor: adding cloud events #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewloux
reviewed
Nov 8, 2019
andrewloux
reviewed
Nov 8, 2019
andrewloux
reviewed
Nov 8, 2019
| } | ||
|
|
||
| return msg, nil | ||
| } |
There was a problem hiding this comment.
think we should be able to remove this Message type here, the CloudEvent type makes it redundant i think 🤔
There was a problem hiding this comment.
Yeah, I think we may use it for internal representation. Because the ack information maybe handy for features. Wdyt?
katallaxie
force-pushed
the
cloud_event
branch
from
303a05a to
289f74a
Compare
katallaxie
commented
Nov 8, 2019
| // Marshaler ... | ||
| type Marshaler interface { | ||
| Marshal(interface{}) ([]byte, error) | ||
| Unmarshal([]byte, interface{}) error |
There was a problem hiding this comment.
@andrewlouis93 changed the cloud events to internal representation.
|
LGTM :) awesome work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.