Add support for configuration files #2
Conversation
Introduce new configuration class which can parse configuration files in YAML format, according to the stub specification defined in https://github.com/andersinno/django-sanitized-dump/blob/c4ba725/README.md#example-config
Modify the CLI utility so that it supports reading configuration from a file.
Add eggs into `.gitignore` as we do not want to store them in GitHub.
Instead of executable scripts, I was recommended to use `setup.cfg` instead, so migrate from `setup.py` to `setup.cfg` instead.
Test (almost) every possible odd situation which might be encountered during configuration parsing.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
===========================================
+ Coverage 70.76% 81.91% +11.15%
===========================================
Files 6 8 +2
Lines 171 376 +205
===========================================
+ Hits 121 308 +187
- Misses 50 68 +18
Continue to review full report at Codecov.
|
Main entry point of the package does not work properly, because it's expected to be always callable. Convert contents of `__main__.py` into a function and point into that function in `setup.cfg` to fix the issue.
There was a problem hiding this comment.
Fantastic work! Could not find anything wrong with the code.
The only thing that reacted to was that the Configuration class was handling the sanitization. But I don't know of a better way to do it either and it is not like it is causing any problem. Just did not expect the config object to do the work as well as keep the config. I don't think this needs to be changed, just wanted to point that out.
|
Configuration is pretty much the only common thing available to all database backends, so it makes sense to me that the method which just calls the already imported sanitation functions should be located there. |
2 participants
Add support for configuration files, as described in this stub specification of sorts.