CV3-85 Add device downtime to report data

[raymond42]

Description

When the analytics report data are retrieved, it should also include the downtime of the device i.e the time the device has been not used.

Type of change

Please select the relevant option

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Others (cosmetics, styling, improvements)
• This change requires a documentation update

How Has This Been Tested?

• Unit
• Integration
• End-to-end

How to Test

• Check the code climate report to see if any file from the fixtures folder violates the file-line-limit
• Follow the instructions on the readme.md file on running tests. Check to see if tests run successfully

Checklist

• My changes generate no new warnings
• My code follows the style guidelines of this project
• I have linted my code prior to submission
• Existing unit tests pass locally with my changes
• Implementation works according to expectations

How to Test

• URL: http://localhost:8000/mrm
• HTTP: POST
• In the query of getting all analytics, you should also include the device analytics that has deviceName, deviceId, and downTime as shown in an example below

query{
  allAnalytics(startDate: "jul 11 2018", endDate: "jul 12 2018", locationId: 1) {
    checkinsPercentage
    appBookingsPercentage
    autoCancellationsPercentage
    cancellationsPercentage
    bookings
    analytics {
      roomName
      cancellations
      cancellationsPercentage
      autoCancellations
      numberOfBookings
      checkins
      checkinsPercentage
      bookingsPercentageShare
      appBookings
      appBookingsPercentage
      events {
        durationInMinutes
      }
    }
    bookingsCount {
      totalBookings
      period
    }
    deviceAnalytics {
      deviceName
      deviceId
      downTime
    }
  }
}

• Expected response

{
  "data": {
    "allAnalytics": {
      "checkinsPercentage": 0.0,
      "appBookingsPercentage": 0.0,
      "autoCancellationsPercentage": 0.0,
      "cancellationsPercentage": 0.0,
      "bookings": 13,
      "analytics": [
        {
          "roomName": "Kampala",
          "cancellations": 0,
          "cancellationsPercentage": 0.0,
          "autoCancellations": 0,
          "numberOfBookings": 0,
          "checkins": 0,
          "checkinsPercentage": 0.0,
          "bookingsPercentageShare": 0.0,
          "appBookings": 0,
          "appBookingsPercentage": 0.0,
          "events": [
            {
              "durationInMinutes": 0
            }
          ]
        }
      ],
      "bookingsCount": [
        {
          "totalBookings": 7,
          "period": "Jul 11 2018"
        },
        {
          "totalBookings": 6,
          "period": "Jul 12 2018"
        }
      ],
      "deviceAnalytics": [
        {
          "deviceName": "Apple tablet",
          "deviceId": 1,
          "downTime": "this device was seen 3 days, 23 hours, 13 minutes ago."
        },
        {
          "deviceName": "Samsung Flat screen",
          "deviceId": 2,
          "downTime": "this device was seen 8 months, 7 days, 2 hours, 44 minutes ago."
        }
      ]
    }
  }
}

JIRA

CV3-85

[adafia]

Please update the "How to test" section of your PR.
Also, indent the body of your commit message.

[adafia]

You don't need the "# noqa" at the end of this line.

[raymond42]

Done. Thank you for the feedback @adafia

[adafia]

Good job @raymond42, it looks good. Just attend to the comments I made and revert back to me.

[raymond42]

Please update the "How to test" section of your PR.
Also, indent the body of your commit message.

Oh yes. Done. Thank you @adafia

[raymond42]

Good job @raymond42, it looks good. Just attend to the comments I made and revert back to me.

Thank you @adafia. All done

[shaluchandwani]

Good work on the PR @raymond42. It looks fine to me.