Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config argument #129

Closed
wants to merge 2 commits into from
Closed

Add config argument #129

wants to merge 2 commits into from

Conversation

nwmcsween
Copy link

Untested, This allow specifying a config relative to the git repo and is useful for monorepo setups

@luhring luhring requested a review from kzantow October 18, 2021 16:20
kzantow
kzantow requested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent idea. I think we'd need to get the docs updated in order to get this merged, add tests, and probably change the input parameter name.

index.js Outdated Show resolved Hide resolved
nwmcsween and others added 2 commits November 2, 2021 07:14
@nwmcsween
Add config argument
f1269e5 
Untested, This allow specifying a config relative to the git repo and is useful for monorepo setups

Signed-off-by: Nathan McSween <nwm@ioc.tl>
@nwmcsween @kzantow
Update index.js
cbf0a2a 
Co-authored-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Nathan McSween <nwm@ioc.tl>
@kzantow
Copy link
Contributor

kzantow commented Apr 6, 2022 •
edited
Loading

Hi @nwmcsween , sorry for the delay getting back to this -- I think we should name this parameter grype-config, and we need to add some basic tests for this, even if it's just verifying the grype command is invoked properly. I could probably help with this, would you be opposed to me pushing a commit to your branch for this?

@spiffcs spiffcs self-requested a review May 26, 2022 13:20
@spiffcs
Copy link
Contributor

spiffcs commented May 26, 2022

@kzantow I can take a look here today and bring this across the finish line.

@spiffcs spiffcs self-assigned this May 26, 2022
@spiffcs spiffcs removed their request for review May 26, 2022 13:21
@spiffcs
Copy link
Contributor

spiffcs commented Jun 10, 2022

Todo:

  • Update Docs
  • Add Tests
  • Change input parameter name

@jacobwoffenden jacobwoffenden mentioned this pull request Mar 9, 2023
Open
@nwmcsween nwmcsween closed this by deleting the head repository Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow requested changes

Assignees

@spiffcs spiffcs

Labels
None yet
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmcsween @kzantow @spiffcs