Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Update docker entrypoint with exact cert path - #1173

Merged
rbrady merged 1 commit into
masterfrom
certifi-path-update
Aug 17, 2021
Merged

Update docker entrypoint with exact cert path#1173
rbrady merged 1 commit into
masterfrom
certifi-path-update

Conversation

@rbrady

@rbrady rbrady commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

The previous fix to this file dynamically found the Python version, but assumed the rest of the path to the certificate.
This patch uses the python3 -m certifi command which returns the exact path of the certifi cacert.pem file. This will
be resilient through Python version changes.

Co-Authored-By: James Petersen jpetersenames@gmail.com
Co-Authored-By: Vijay Pillai vijay.pillai@anchore.com

Signed-off-by: Ryan Brady ryan.brady@anchore.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>)(, fixes #<issue_number, ...) format, will close the issue when PR is merged: fixes #:

Special notes:

@rbrady
rbrady requested review from Toure and Vijay-P August 17, 2021 18:51

@Vijay-P Vijay-P left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vijay-P

Vijay-P commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

Corresponding PR in enterprise: https://github.com/anchore/enterprise/pull/645

The previous fix to this file dynamically found the Python version, but assumed the rest of the path to the certificate.
This patch uses the `python3 -m certifi` command which returns the exact path of the certifi cacert.pem file.  This will
be resilient through Python version changes.

Co-Authored-By: James Petersen <jpetersenames@gmail.com>
Co-Authored-By: Vijay Pillai <vijay.pillai@anchore.com>

Signed-off-by: Ryan Brady <ryan.brady@anchore.com>
@rbrady
rbrady force-pushed the certifi-path-update branch from 5ec49b1 to 173875a Compare August 17, 2021 19:20

@Toure Toure left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rbrady
rbrady merged commit efdf3d5 into master Aug 17, 2021
@rbrady
rbrady deleted the certifi-path-update branch August 17, 2021 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants