Do not collapse quote notifications

This prevents an issue where edits to a post with a quote would trigger push notifications indefinitely.
anantgarg · Jun 27, 2019 · 27387b0 · 27387b0
1 parent 4ba3547
commit 27387b0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/services/post_alerter.rb b/app/services/post_alerter.rb
@@ -271,7 +271,6 @@ def should_notify_previous?(user, notification, opts)
 
   COLLAPSED_NOTIFICATION_TYPES ||= [
     Notification.types[:replied],
-    Notification.types[:quoted],
     Notification.types[:posted],
     Notification.types[:private_message],
   ]

diff --git a/spec/services/post_alerter_spec.rb b/spec/services/post_alerter_spec.rb
@@ -184,7 +184,7 @@ def create_post_with_alerts(args = {})
       }.to change(evil_trout.notifications, :count).by(0)
     end
 
-    it 'notifies a user by username' do
+    it 'does not collapse quote notifications' do
       topic = Fabricate(:topic)
 
       expect {
@@ -194,7 +194,7 @@ def create_post_with_alerts(args = {})
             topic: topic
           )
         end
-      }.to change(evil_trout.notifications, :count).by(1)
+      }.to change(evil_trout.notifications, :count).by(2)
     end
 
     it "won't notify the user a second time on revision" do