Empty Search fix and search edit #408
Open
+32
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandnet
reviewed
Jan 23, 2025
anandnet
reviewed
Feb 12, 2025
| child: Text( | ||
| "${"for1".tr} \"${searchResScrController.queryString.value}\"", | ||
| style: Theme.of(context).textTheme.titleLarge, | ||
| ), |
There was a problem hiding this comment.
Sorry for delay in response. Please move gesture detector above this widget instead of whole.
There was a problem hiding this comment.
i have checked titleLarge does not seems good for small screen and also if user have long search string. Please revert that to titleMedium.
anandnet
force-pushed
the
main
branch
5 times, most recently
from
9c53642 to
53d39ea
Compare
|
@anandnet I have made the changes you have asked, not sure why the checks are failing. Can you check once? |
|
No worries, will check it tomorrow and let you know. |
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes makes sure that the user is not able to make empty searches i.e. search for nothing (" ") and also removes leading and trailing spaces from searches, which doesn't look that good (eg below). Beside this, this PR also include change requested in issue #391 and now allows user to edit the searched text by tapping on it.
(A slight change is made in search result header, making the actual searched text bigger and making the 'Search results' text smaller, as it seemed a bit more logical to me to highlight the actual text)