Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra class in Tailwind/trpc example #772

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

ajitzero
Copy link
Contributor

@ajitzero ajitzero commented Dec 2, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin (not really sure?)
  • trpc

What is the current behavior?

In the welcome component, we use text-xs and text-sm on the same element, so text-xs gets ignored.

Closes N/A

What is the new behavior?

I removed the extra tailwind class: text-xs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit c2f3af2
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/656bb506489537000837fdef
😎 Deploy Preview https://deploy-preview-772--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit c2f3af2
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/656bb5061244d400084bccc9
😎 Deploy Preview https://deploy-preview-772--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit c2f3af2
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/656bb50613970700078a0bbe
😎 Deploy Preview https://deploy-preview-772--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ajitzero ajitzero changed the title fix: Redundant class in Tailwind with trpc example fix: Remove extra class in Tailwind/trpc example Dec 2, 2023
@brandonroberts brandonroberts changed the title fix: Remove extra class in Tailwind/trpc example fix: remove extra class in Tailwind/trpc example Dec 4, 2023
@brandonroberts brandonroberts merged commit b5ee6d5 into analogjs:main Dec 4, 2023
16 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @ajitzero for code

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @ajitzero! 🎉

@ajitzero ajitzero deleted the patch-1 branch December 4, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants