Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Nx 19.5.3 and Angular 18.2.x #1348

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

benpsnyder
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 68e94c5
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66e6696c337e7e0008ecfd21
😎 Deploy Preview https://deploy-preview-1348--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 68e94c5
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66e6696cfe76cf0008e4ad5c
😎 Deploy Preview https://deploy-preview-1348--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 68e94c5
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66e6696c8ae44100089c98b1
😎 Deploy Preview https://deploy-preview-1348--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 68e94c5
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66e6696cfb67f90008a300cf
😎 Deploy Preview https://deploy-preview-1348--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benpsnyder
Copy link
Contributor Author

@brandonroberts
Copy link
Member

@benpsnyder everything is building correctly on Vercel. I'm wondering why there are so many touched files though? Did the Nx migration do this?

@benpsnyder
Copy link
Contributor Author

@benpsnyder everything is building correctly on Vercel. I'm wondering why there are so many touched files though? Did the Nx migration do this?

@brandonroberts some notes

  • I had to remove "outputs": ["{workspaceRoot}/{options.outputPath}"], to get the builds to work and didn't see any negative impact.
  • regarding apps/docs-app/package.json if memory serves me, I had to update package versions to get docusaurus happily building
  • NODE_OPTIONS memory had to be increases otherwise builds were failing due to insufficient memory
  • Change of backticks to single quotes on some files was due to biomejs; I could revert those if you want

@brandonroberts brandonroberts merged commit 4e3c6e6 into analogjs:beta Sep 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants