Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): use workspace root when discovering packages for SSR transform #1280

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #

What is the new behavior?

Fixes an issue where packages that need SSR transform were not discovered when creating an Nx workspace using the Analog preset.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 44464df
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66c25be66c3ed00008dc40ef
😎 Deploy Preview https://deploy-preview-1280--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 44464df
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66c25be67f12df00081cd048
😎 Deploy Preview https://deploy-preview-1280--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 44464df
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66c25be60165b1000971a2aa
😎 Deploy Preview https://deploy-preview-1280--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 44464df
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66c25be6a6838e0008eb3f05
😎 Deploy Preview https://deploy-preview-1280--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit fa82328 into beta Aug 19, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-root-ssr-deps branch August 19, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant