Make HTTP client exchangable #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an Interface that defines what a suitable HTTPClient needs to provide and makes it possible to pass an alternative implementation in the Lescript constructor.
|
Was wondering why there needs to be a dependency on curl or some other HTTP client in the first place. |
Contributor
|
At this point the project should probably have separate files for each interface/class/etc. Makes organization much easier. |
Author
|
I am happy to split it up into multiple files if that's what is wanted. |
Owner
|
@maxnet you are right! |
Author
|
Uhm thanks for incorporating my changes. Though a true merge (and thus giving proper credit in the commit history) would have been the decent thing to do. |
splitbrain
added a commit
to splitbrain-forks/lescript
that referenced
this pull request
Aug 21, 2016
* master: Example for #12 - adding LE registration contact Fix analogic#18 - make HTTP client exchangable Fix analogic#19 - Allow Defining challenge type Add #12 - adding LE registration contact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an Interface that defines what a suitable HTTPClient needs to provide and makes it possible to pass an alternative implementation in the Lescript constructor.
PS: I can provide another PullRequest introducing doc blocks to all other methods if you're interested. DocBlocks make working with a library much easier IMHO. just let me know.