Skip to content

testbenches/ip/util_axis_fifo: include test with random tkeep #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 24, 2025
Merged

testbenches/ip/util_axis_fifo: include test with random tkeep #246

merged 5 commits into from
Sep 24, 2025

Conversation

@LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Sep 12, 2025

  • Add support for user-defined tkeep on m_axis_sequencer,
  • Add test_tkeep to util_axis_fifo, with random tkeep
  • Add cfg_tkeep to util_axis_fifo, which forces TKEEP_EN=1

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • New test (change that adds new test program and/or testbench)
  • Breaking change (has dependencies in other repositories/testbenches)
  • Documentation (change that adds or modifies documentation)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have ran all testbenches affected by this PR
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Errors on compilation/elaboration/simulation
  • I have set the verbosity level to none for the test program

github-actions bot added a commit that referenced this pull request Sep 12, 2025
@github-actions
deploy: bbe7597 #246 (opened)
ad0625d
@LBFFilho LBFFilho mentioned this pull request Sep 12, 2025
Draft
13 tasks
caosjr
caosjr reviewed Sep 17, 2025
View reviewed changes
caosjr
caosjr reviewed Sep 17, 2025
View reviewed changes
caosjr
caosjr reviewed Sep 17, 2025
View reviewed changes
@LBFFilho
testbenches/ip/util_axis_fifo: include test with random tkeep
362e158 
- Add support for user-defined tkeep on m_axis_sequencer,
- Add test_tkeep to util_axis_fifo, with random tkeep
- Add cfg_tkeep to util_axis_fifo, which forces TKEEP_EN=1

Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
@LBFFilho
fix parameterization
e9bec00 
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
@LBFFilho
update makefile for multiple tests
eff72fb 
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
github-actions bot added a commit that referenced this pull request Sep 22, 2025
@github-actions
deploy: 3a83266 #246 (synchronize)
02c5362
IstvanZsSzekely
IstvanZsSzekely requested changes Sep 23, 2025
View reviewed changes
@LBFFilho
sequencer review
e3757d1 
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
github-actions bot added a commit that referenced this pull request Sep 23, 2025
@github-actions
deploy: 85aad6f #246 (synchronize)
bf38980
@LBFFilho LBFFilho marked this pull request as ready for review September 23, 2025 18:19
@LBFFilho LBFFilho requested a review from a team as a code owner September 23, 2025 18:19
IstvanZsSzekely
IstvanZsSzekely requested changes Sep 24, 2025
View reviewed changes
@caosjr
Copy link

caosjr commented Sep 24, 2025

I have tested again and everything is passing.

caosjr
caosjr previously approved these changes Sep 24, 2025
View reviewed changes
@LBFFilho
remove extra empty lines
5379589 
except ones preceding the start of a class declaration

Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
github-actions bot added a commit that referenced this pull request Sep 24, 2025
@github-actions
deploy: 496400f #246 (synchronize)
ba8009a
@LBFFilho LBFFilho merged commit 9fa098b into main Sep 24, 2025
2 checks passed
@LBFFilho LBFFilho deleted the asym_fifo_tkeep branch September 24, 2025 16:25
github-actions bot added a commit that referenced this pull request Sep 24, 2025
@github-actions
deploy: 9fa098b #246 (closed)
b4ed590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IstvanZsSzekely IstvanZsSzekely IstvanZsSzekely approved these changes

@caosjr caosjr caosjr left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LBFFilho @caosjr @IstvanZsSzekely