Skip to content

AD4630-20 support#3119

Open
machschmitt wants to merge 2 commits into
analogdevicesinc:mainfrom
machschmitt:ad4630-20-support
Open

AD4630-20 support#3119
machschmitt wants to merge 2 commits into
analogdevicesinc:mainfrom
machschmitt:ad4630-20-support

Conversation

@machschmitt
Copy link
Copy Markdown
Contributor

Pull Request Description

Extend AD463x device driver and project to also support AD4630-20 and similar 20-bit precision ADCs.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

AD4630-20, AD4631-20, and AD4632-20 default output mode is 20-bit
precision. Consider the proper amount of data precision when using one of
those. While at it, also set 16-bit default precision for AD4630-16 and
similar ADCs.

Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Add support for 20-bit precision AD4630-20 and similar ADCs.

Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Copy link
Copy Markdown
Contributor

@rbolboac rbolboac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit from my side

Comment on lines +763 to +765
case ID_AD4630_16:
case ID_AD4631_16:
case ID_AD4632_16:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this in a different commit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants