Skip to content

Conversation

Carlian275
Copy link

Added the README file for the MAX11205PMB1 project.

Modified the sphinx projects_doc.rst file to add the corresponding source.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

Added the README file for the MAX11205PMB1 project.

Modified the sphinx projects_doc.rst file to add the corresponding
source.

Signed-off-by: Carl Ian Gamutan <Carlian.Gamutan@analog.com>
@Carlian275 Carlian275 changed the title [project:max11205pmb1: Added README documentation for MAX11205PMB1.] project:max11205pmb1: Added README documentation for MAX11205PMB1. Sep 30, 2025
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carl,

Some comments, if you have questions, please feel free to ask.

About recursively updating, I had something similar at
analogdevicesinc/documentation#56
to change local references to cross-repo references

find . -type f -name "*.rst" -exec sed -i -E 's|(^\|[[:space:]]):ref:`([^<]+) <kuiper sdcard>`|\1:external+adi-kuiper-gen:doc:`\2 <use-kuiper-image>`|g' {} \;
find . -type f -name "*.rst" -exec sed -i -E 's|(^\|[[:space:]]):ref:`(kuiper sdcard`|\1:external+adi-kuiper-gen:doc:`use-kuiper-image`|g' {} \;

You could do something similar for the hard-coded urls

@@ -0,0 +1,176 @@
MAX11205PMB1 no-OS Example Project
==================================

Copy link
Contributor

@gastmaier gastmaier Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Must]

Suggested change
.. no-os-doxygen::

every doc page that contains a doxygen doc should contain the .. no-os-doxygen:: directive.
It will auto create a

"See projects/ad405x (doxygen) for the Doxygen documentation."

automatically resolving the obnoxious doxygen generated url dir_f05c786dc4c770a23b7a3f54fd92d3b6.html.

Please do the same for all pages.

------------------------

The initialization data used in the examples is taken out from:
`Project Common Data Path <https://github.com/analogdevicesinc/no-OS/tree/main/projects/max11205pmb1/src/common>`__
Copy link
Contributor

@gastmaier gastmaier Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion]

This can be shortened as

Suggested change
`Project Common Data Path <https://github.com/analogdevicesinc/no-OS/tree/main/projects/max11205pmb1/src/common>`__
:git-no-OS:`projects/max11205pmb1/src/common`

but it is a suggestion, if the other pages are not using, I wouldn't start bothering right now, instead, recursively replace in a future opportunity.

https://analogdevicesinc.github.io/doctools/docs_guidelines/roles.html#git

customizable buffer sizes.

If you are not familiar with ADI IIO Application, please take a look at:
`IIO No-OS <https://wiki.analog.com/resources/tools-software/no-os-software/iio>`__
Copy link
Contributor

@gastmaier gastmaier Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion]

Suggested change
`IIO No-OS <https://wiki.analog.com/resources/tools-software/no-os-software/iio>`__
:dokuwiki:`IIO No-OS <resources/tools-software/no-os-software/iio>`

https://analogdevicesinc.github.io/doctools/docs_guidelines/roles.html#dokuwiki

But I don't understand why is this being linked still, there is no github.io equivalent page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants