-
Notifications
You must be signed in to change notification settings - Fork 882
Add support for ADA4355 #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for ADA4355 #2806
Conversation
3e5593e
to
dd3c40b
Compare
Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
|
||
config ADA4355 | ||
tristate "Analog Devices ADA4355 uModule Data Acquisition Module" | ||
depends on SPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: my comment looks into why it was lacking symbols, nuno suggestion is the correct solution.
depends on SPI | |
depends on SPI | |
depends on CF_AXI_ADC |
The driver uses axiadc_write and axiadc_read, exported from cf_axi_adc_core.c, enabled with CF_AXI_ADC.
So the driver depends on this symbol as well.
Without this change, it cannot be compiled as a module without blindly enabling symbols.
This is an issue in other drivers.
For curiosity, we have now a script that resolves the tree of depends in the KConfig based on a target:
$ python3 ci/symbols_depend.py drivers/iio/adc/ada4355.o
Symbols of touched files:
{'ADA4355'}
Resolved symbols:
{'PCI', 'IIO_BUFFER', 'HAS_IOMEM', 'HAVE_PCI', 'ADA4355', 'SPI', 'IIO'}
as committed, it lacks the CF_AXI_ADC symbol.
Add driver for ADA4355. Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
#include <linux/iio/iio.h> | ||
#include <linux/iio/sysfs.h> | ||
|
||
#include "cf_axi_adc.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using the above and not the new IIO backend framework? That's what we want to use for all new drivers interfacing with the AXI ADC IP. This also makes it possible to upstream the driver.
PR Description
The ADA4355 is a complete, high performance, current input µModule. The 14-bit ADC converts the amplified voltage signal at a rate of up to 125 MSPS and outputs the digitized signals through two serial, low voltage differential signaling (LVDS) data lanes. The data clock output (DCO) operates at frequencies of up to 500 MHz and supports double data rate (DDR) operation.
This driver is also in the process of upstreaming.
PR Type
PR Checklist