Fix Impulse Generator Menu #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iio_device_get_trigger will return 0 on success, but if there is no device assigned to the trigger, the trigger pointer will be NULL. since the impulse generator menu sets the trigger, the condition will not be satisfied. this resulted in the impulse generator menu being grayed out. Now, we will only check that the return value is 0. The renaming of the bool variable is to avoid confusion. Signed-off-by: Cristina Suteu <cristina.suteu@analog.com>
dNechita
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
iio_device_get_trigger will return 0 on success, but if there is no device assigned to the trigger, the trigger pointer will be NULL. since the impulse generator menu sets the trigger, the condition if (ret == 0 && trigger) will not be satisfied. this resulted in the impulse generator menu being grayed out. Now, we will only check that the return value is 0, to see if our device needs a trigger, which will be configured in the menu. The renaming of the bool variable to needs_trigger is to avoid confusion.
PR Type
PR Checklist