Why is torrent read lock at CLient level?

[vijayanandnandam]

Any specific reason why lock is always at client level and not a torrent level for torrent specific functions? I am facing issues when downloading torrents with a queue size of >= 100. The client seems to hang after sometime. It always hangs when trying to execute, torrent.BytesCompleted function.

[anacrolix]

Mainly as a simplification. There are some features that operate across the whole client, such as storage prioritization and request handling, common trackers, global connection limits etc. If you provide specific examples, like the BytesCompleted method I can check in to it.

[anacrolix]

I didn't change the locking, but try torrent@master, I made a few tweaks that might improve things. Please send or share a CPU performance profile if you can.

[vijayanandnandam]

@anacrolix let me try it with the master. I am not sure how to share the CPU profile. Pls guide me. I can share the code in private gist if you want to take a look

[anacrolix]

With https://github.com/anacrolix/envpprof imported, run with GOPPROF=http and send the file generated after running go pprof http://envpprof:handler/debug/pprof/profile or GOPPROF=cpu, and its corresponding profile when the binary completes.

Feel free to share a gist with me, but if it's not easy to reproduce, the profiles might be better.

[vijayanandnandam]

Have sent the details to to your emails.

[vijayanandnandam]

There is huge contention for mutex lock. Let me know if you want a code walk through. If reading takes too much time. All it is doing is

• Get magnet from redis
• Add to client
• save torrent file once it got the info
• download all files
• Periodically check for download status of all torrents and stop downloaded ones.
• It drop torrents if it cannot fetch magnet link within 300s. Drop torrents that are completed

[anacrolix]

This issue has moved into a private email dialogue. The fix 16c4b08 should directly address the described issue, and some other fixes resulted while working through it.

[vijayanandnandam]

We can close this discussion. The main problem is solved and fixed

[anacrolix]

I think you can mark #547 (comment) as an answer to "close" this discussion.