-
-
Notifications
You must be signed in to change notification settings - Fork 102
Added subtitle support. Fixes#35 #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1b6191d
to
2de667e
Compare
Thanks, I've mentioned it in the linked issue to get hopefully get some outside input. |
You could crawl the directory that the video is in, for a file with a conforming mimetype; we have mimesniff support in the http package. Personally I just remuxed my files to include the subtitles, but it would be great to not have to |
I've downloaded the repo, made the suggested changes in this PR and built it locally on Windows. First test was my phone running just plain VLC. It worked flawlessly. External subs were served(?) with their respective videos. Second test was my "smart" TV running bubbleupnp as VLC has a bug/oversight that it doesn't start scanning unless the device running VLC is explicitly connected to a network instead of being in a network (such as opening a hotspot as is the case with my TV). I happen to find another program called nano-dlna. It seems to have no problems serving a subtitle file that both VLC and bubbleupnp picked up. Although, in its current state, only a single file could be served. That said, great work. I like this project. |
Thank you @jakima. This project likes you too. I think I'll merge this PR shortly based on your feedback. It's also a very tidy PR. |
Thanks @jakima and @abdullah2993 . |
I have a domestic-brand TV with a basic DLNA player app by which the subtitles (.srt) file cannot be scanned/detected, even though i renamed the srt filename to exactly the video file name. any suggestions? thanks. |
It's been a while but the first thing that comes to mind is to check the mime type for .srt files on your system. |
thanks but where to config the mime type of .srt? |
Also do try to play the same using vlc on a computer or using mx player on your android phone. Just to rule out any issues related to naming. |
Added support for subtitle, It works but this might not be the most elegant solution. IMO the best approach should be to find subtitle files based on filename when walking the FS and then only add the subtitle res for objects for which the subtitles were found.
Fixes #35