Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--image flag seems to be ignored? #66

Closed
hulkholden opened this issue Jul 8, 2023 · 2 comments
Closed

--image flag seems to be ignored? #66

hulkholden opened this issue Jul 8, 2023 · 2 comments
Labels
released

Comments

@hulkholden
Copy link

I'm not sure if I'm interpreting this correctly, but when I pass --image to use the unstable branch, the CLI still seems to pull the :latest version:

% libdragon init --image ghcr.io/dragonminded/libdragon:unstable
Initializing a libdragon project at /.../test3
Downloading docker image: ghcr.io/dragonminded/libdragon:latest
latest: Pulling from dragonminded/libdragon
Digest: sha256:b658097719451d994ced50f10b72692b07c2264d260ab9956bf97987761baf3c
Status: Image is up to date for ghcr.io/dragonminded/libdragon:latest
ghcr.io/dragonminded/libdragon:latest
Creating new container...
@anacierdem
Copy link
Owner

Looks weird indeed. Should not be a problem in practice as currently unstable does not have any toolchain changes. Worth investigating of course, thank you for reporting.

github-actions bot pushed a commit that referenced this issue Feb 9, 2024
@semantic-release-bot
chore(release): 11.0.1 [skip ci]
a60aaaa 
## [11.0.1](v11.0.0...v11.0.1) (2024-02-09)

### Bug Fixes

* **init.js:** make sure providing --image flag uses the provided image ([965fe41](965fe41)), closes [#66](#66)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

🎉 This issue has been resolved in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hulkholden @anacierdem