Fix time logic for evovle_for in mesa 2208 #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the evolution will stop exactly at the time requested instead of a bit afterwards. Note evovle_for doesn't need to set target_times and evolve_one_step is doing that for us.
rieder
approved these changes
Apr 4, 2023
LourensVeen
added a commit
to LourensVeen/amuse
that referenced
this pull request
Jul 26, 2024
Tests are still failing because amusecode#933 changed the behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the evolution will stop exactly at the time requested instead of a bit afterwards.
Note evovle_for doesn't need to set target_times and evolve_one_step is doing that for us.