bug in seba_time after recall_memory_one_step in SeBa interface #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do other stellar evolution codes have the same bug?
Member
|
What does this do? It only seems to calculate seba_time, which is then not used anywhere... |
Contributor
Author
|
Hi Steven,
this is related to the bug I reported weeks ago. seba_time is used in other functions, e.g. to calculate the timesteps in the SeBa interface (not in SeBa as a stand-alone code). When you require the code to revert back to the previous time step therefore the seba_time needs to be reset as well. Otherwise I ran into the situation where the next timestep is earlier than the seba_time, and the timestep amuse will ask SeBa to do is negative, such that the goal time is never reached, and the code doesn't break out of the do loop - aka keeps on running - seems to freeze.
|
Member
|
I'm trying to find that issue, but I can't find it. Did we just discuss it in person? |
Contributor
Author
|
Hi Steven,
I reported it in the SeBa github and amuse github as a suggested change and added simon and you to it, I've also emailed about it and we chatted about it :)
Cheers Silvia
|
Member
|
Ah I see it now - it was already closed there! amusecode/SeBa#18 |
rieder
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do other stellar evolution codes have the same bug?