Skip to content

Allow overriding the close_fds option to Popen. #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ipelupessy merged 1 commit into from
Nov 2, 2021
Merged

Allow overriding the close_fds option to Popen. #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/amuse/rfi/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1846,7 +1846,7 @@ def start(self):
arguments.append('false')

logger.debug("starting process with command `%s`, arguments `%s` and environment '%s'", command, arguments, os.environ)
self.process = Popen(arguments, executable=command, stdin=PIPE, stdout=None, stderr=None, close_fds=True)
self.process = Popen(arguments, executable=command, stdin=PIPE, stdout=None, stderr=None, close_fds=self.close_fds)
logger.debug("waiting for connection from worker")

self.socket, address = self.accept_worker_connection(server_socket, self.process)
Expand All @@ -1862,7 +1862,10 @@ def start(self):
# logger.info("worker %s initialized", self.name_of_the_worker)



@option(type="boolean", sections=("sockets_channel",))
def close_fds(self):
"""close open file descriptors when spawning child process"""
return True

@option(choices=AbstractMessageChannel.DEBUGGERS.keys(), sections=("channel",))
def debugger(self):
Expand Down