Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding initial conditions for Oort cloud-like particle set and test #43

Merged
merged 3 commits into from
Mar 8, 2016

Conversation

jilkoval
Copy link
Contributor

@jilkoval jilkoval commented Mar 2, 2016

A class SphericalIsotropicCloud to create a isotropic Oort cloud-like particle set and a test:
"""
Spherical isotropic (Oort) cloud -- initial conditions for a particle set

See for example:

Initial conditions -- given by distributions of orbital elements:
semi-major axes -- power law, default: dn/da ~ a^(-1.5),
eccentricities -- dn/de ~ e,
constrain on the minimum pericenter,
isotropic orbits -- distribution of orbital inclinations: cos(i) = -1--1,
longitude of ascending node: 0--2pi,
argument of periastron: 0--2pi,
mean anomaly: 0--2pi,
equal mass particles.
"""

@ipelupessy
Copy link
Member

two comments:
maybe put it in amuse/ic, and can you change the docstring style for the aruments to match:

:argument number_of_particles: Number of particles to include in the plummer sphere

@jilkoval
Copy link
Contributor Author

jilkoval commented Mar 3, 2016

done

@ipelupessy
Copy link
Member

ok, also..can you add a factory function (like new_plummer_model)??

also you may find it useful that:

peri.value_in(units.AU)<min_peri.value_in(units.AU)

gives you the same as:

peri<min_peri

ipelupessy added a commit that referenced this pull request Mar 8, 2016
adding initial conditions for Oort cloud-like particle set and test
@ipelupessy ipelupessy merged commit 4c7a3f0 into amusecode:master Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants