fix for N+1 message length problem #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also this needs a test, but I have not yet reproduced it independent of Fi (the bug is not fi related) |
|
I have simplified some more (I think call_count=1 is actually an error), but some of it crossed with 994a593, I think it merged ok, but please double check.. |
|
it could be I am misunderstanding the reason for the call_count=1 case, and oversimplifying. tests are ok here I think, so if that is the case a test case is needed... |
ipelupessy
added a commit
that referenced
this pull request
Feb 22, 2016
fix for N+1 message length problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this seems to fix #38, I think it was assumed call_count was evaluated at function def time, but it evaluated when the function is callend, call_count is changed in the loop.
however there may be deeper problems with the way split_input_array is used...and it does not look particularly efficient for call_counts=1