Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support both rc.threaded and rc.threads #27

Merged
merged 4 commits into from
Jan 10, 2016
Merged

support both rc.threaded and rc.threads #27

merged 4 commits into from
Jan 10, 2016

Conversation

launerbie
Copy link
Contributor

This PR should resolve #26. It adds support for mpi4py 2.0.0 which seems to have dropped the variable rc.threaded in favor of rc.threads.

@launerbie launerbie mentioned this pull request Jan 6, 2016
Closed
@arjenve
Copy link
Contributor

arjenve commented Jan 8, 2016

Good catch!, I would suggest extracting the rc.threaded / rc.threads query into a method (that uses the try).

@launerbie
Copy link
Contributor Author

Something like this 1746958 maybe?

edit
Turns I out I hadn't tested 1746958.
This commit 0909c5a should be a better candidate.

arjenve added a commit that referenced this pull request Jan 10, 2016
@arjenve
Merge pull request #27 from iambernie/issue26
daffd93 
support both rc.threaded and rc.threads
@arjenve arjenve merged commit daffd93 into amusecode:master Jan 10, 2016
@launerbie launerbie deleted the issue26 branch January 10, 2016 17:46
@ipelupessy ipelupessy mentioned this pull request Jan 31, 2016
Closed
@launerbie launerbie mentioned this pull request May 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpi4py or openmpi issues on Ubuntu 12.04
2 participants
@launerbie @arjenve