Patch cleanupseba #203
Merged
Patch cleanupseba #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull updates from master branch
|
maybe ask @silviatoonen if it the tmp can be removed ? btw whence the merges? (I think they do no harm, but it seems strange that especially the #3 should show up seperately??) |
|
Hi Inti,
I recently submitted several changes to Seba, but from your mail it's not
clear to me what is the problem. Please send me some more info, and I'd be
happy to have a look at it.
Cheers Silvia
|
|
@silviatoonen: you can have a look at the patch on github, basically it removes: seba/src/include/star/tmp/ and the files therein |
|
The folder tmp does not exist in the original version of SeBa. It seems to
be a copy of a sub-directory in include/star. As far as I can see, it
serves no purpose. According to the GitHub log, the folder was updated last
time 6 years ago by Arjen. Presumably when importing SeBa into SVN back in
the day.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #201