Change arguments of addstar in new_advanced_particle #1097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set all arguments of addstar in new_advanced_particle -- including the relative mass, core mass, and envelope mass -- to ensure that simulations restarted with evolved stars use the correct evolved stellar masses.
cournoyercloutierc
added a commit
to cournoyercloutierc/amuse
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set all arguments of addstar in new_advanced_particle -- including the relative mass, core mass, and envelope mass -- to ensure that simulations restarted with evolved stars use the correct evolved stellar masses. Prior to this change, restarting from stars with non-zero core masses resulted in the total mass being calculated from the mass plus the core mass. The relevant function (from add_star.C) is shown below:
addstar(node * b, real t_current, stellar_type type, real z,int id, bool verbose, stellar_type type2, real m_rel, real m_env, real m_core, real mco_core, real t_rel)No other files are affected by this change.