Skip to content

Commit

Permalink
[ARM] Remove asm/irq.h includes from ARM drivers
Browse files Browse the repository at this point in the history
Many ARM drivers do not need to include asm/irq.h - remove this
unnecessary include from some ARM drivers.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Jan 9, 2006
1 parent 63dcf0a commit e9368f8
Show file tree
Hide file tree
Showing 12 changed files with 10 additions and 16 deletions.
1 change: 0 additions & 1 deletion drivers/amba/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <linux/amba/bus.h>

#include <asm/io.h>
#include <asm/irq.h>
#include <asm/sizes.h>

#define to_amba_device(d) container_of(d, struct amba_device, dev)
Expand Down
1 change: 0 additions & 1 deletion drivers/input/serio/sa1111ps2.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <linux/spinlock.h>

#include <asm/io.h>
#include <asm/irq.h>
#include <asm/system.h>

#include <asm/hardware/sa1111.h>
Expand Down
1 change: 0 additions & 1 deletion drivers/net/arm/ether3.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
#include <asm/system.h>
#include <asm/ecard.h>
#include <asm/io.h>
#include <asm/irq.h>

static char version[] __initdata = "ether3 ethernet driver (c) 1995-2000 R.M.King v1.17\n";

Expand Down
1 change: 0 additions & 1 deletion drivers/net/arm/etherh.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
#include <asm/system.h>
#include <asm/ecard.h>
#include <asm/io.h>
#include <asm/irq.h>

#include "../8390.h"

Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/arm/acornscsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@

#include <asm/system.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/ecard.h>

#include "../scsi.h"
Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/arm/arxescsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

#include <asm/dma.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/ecard.h>

#include "../scsi.h"
Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/arm/cumana_1.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

#include <asm/ecard.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/system.h>

#include "../scsi.h"
Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/arm/cumana_2.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include <asm/dma.h>
#include <asm/ecard.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/pgtable.h>

#include "../scsi.h"
Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/arm/eesox.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include <linux/dma-mapping.h>

#include <asm/io.h>
#include <asm/irq.h>
#include <asm/dma.h>
#include <asm/ecard.h>
#include <asm/pgtable.h>
Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/arm/powertec.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <asm/dma.h>
#include <asm/ecard.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/pgtable.h>

#include "../scsi.h"
Expand Down
1 change: 0 additions & 1 deletion drivers/video/cyber2000fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
#include <linux/init.h>

#include <asm/io.h>
#include <asm/irq.h>
#include <asm/pgtable.h>
#include <asm/system.h>
#include <asm/uaccess.h>
Expand Down
15 changes: 10 additions & 5 deletions drivers/video/sa1100fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@

#include <asm/hardware.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/mach-types.h>
#include <asm/uaccess.h>
#include <asm/arch/assabet.h>
Expand Down Expand Up @@ -1455,7 +1454,11 @@ static struct sa1100fb_info * __init sa1100fb_init_fbinfo(struct device *dev)
static int __init sa1100fb_probe(struct platform_device *pdev)
{
struct sa1100fb_info *fbi;
int ret;
int ret, irq;

irq = platform_get_irq(pdev, 0);
if (irq <= 0)
return -EINVAL;

if (!request_mem_region(0xb0100000, 0x10000, "LCD"))
return -EBUSY;
Expand All @@ -1470,7 +1473,7 @@ static int __init sa1100fb_probe(struct platform_device *pdev)
if (ret)
goto failed;

ret = request_irq(IRQ_LCD, sa1100fb_handle_irq, SA_INTERRUPT,
ret = request_irq(irq, sa1100fb_handle_irq, SA_INTERRUPT,
"LCD", fbi);
if (ret) {
printk(KERN_ERR "sa1100fb: request_irq failed: %d\n", ret);
Expand All @@ -1492,7 +1495,7 @@ static int __init sa1100fb_probe(struct platform_device *pdev)

ret = register_framebuffer(&fbi->fb);
if (ret < 0)
goto failed;
goto err_free_irq;

#ifdef CONFIG_CPU_FREQ
fbi->freq_transition.notifier_call = sa1100fb_freq_transition;
Expand All @@ -1504,7 +1507,9 @@ static int __init sa1100fb_probe(struct platform_device *pdev)
/* This driver cannot be unloaded at the moment */
return 0;

failed:
err_free_irq:
free_irq(irq, fbi);
failed:
platform_set_drvdata(pdev, NULL);
kfree(fbi);
release_mem_region(0xb0100000, 0x10000);
Expand Down

0 comments on commit e9368f8

Please sign in to comment.