Skip to content

Commit

Permalink
Merge branch 'for-linus' of git://git.kernel.dk/linux-block
Browse files Browse the repository at this point in the history
* 'for-linus' of git://git.kernel.dk/linux-block:
  block: Free queue resources at blk_release_queue()
  • Loading branch information
torvalds committed Sep 28, 2011
2 parents e689ec8 + 777eb1b commit c54a06d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
13 changes: 6 additions & 7 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -348,9 +348,10 @@ void blk_put_queue(struct request_queue *q)
EXPORT_SYMBOL(blk_put_queue);

/*
* Note: If a driver supplied the queue lock, it should not zap that lock
* unexpectedly as some queue cleanup components like elevator_exit() and
* blk_throtl_exit() need queue lock.
* Note: If a driver supplied the queue lock, it is disconnected
* by this function. The actual state of the lock doesn't matter
* here as the request_queue isn't accessible after this point
* (QUEUE_FLAG_DEAD is set) and no other requests will be queued.
*/
void blk_cleanup_queue(struct request_queue *q)
{
Expand All @@ -367,10 +368,8 @@ void blk_cleanup_queue(struct request_queue *q)
queue_flag_set_unlocked(QUEUE_FLAG_DEAD, q);
mutex_unlock(&q->sysfs_lock);

if (q->elevator)
elevator_exit(q->elevator);

blk_throtl_exit(q);
if (q->queue_lock != &q->__queue_lock)
q->queue_lock = &q->__queue_lock;

blk_put_queue(q);
}
Expand Down
5 changes: 5 additions & 0 deletions block/blk-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,11 @@ static void blk_release_queue(struct kobject *kobj)

blk_sync_queue(q);

if (q->elevator)
elevator_exit(q->elevator);

blk_throtl_exit(q);

if (rl->rq_pool)
mempool_destroy(rl->rq_pool);

Expand Down

0 comments on commit c54a06d

Please sign in to comment.