Skip to content

Commit

Permalink
[BRIDGE]: recompute features when adding a new device
Browse files Browse the repository at this point in the history
We must recompute bridge features everytime the list of underlying 
devices changes, or we might end up with features that are not
supported by all devices (eg. NETIF_F_TSO)
This patch adds the missing recompute when adding a device to the bridge.

Signed-off-by: Olaf Rempel <razzor@kopf-tisch.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
orempel authored and davem330 committed Nov 24, 2005
1 parent de91982 commit 133747e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/bridge/br_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)

spin_lock_bh(&br->lock);
br_stp_recalculate_bridge_id(br);
br_features_recompute(br);
if ((br->dev->flags & IFF_UP)
&& (dev->flags & IFF_UP) && netif_carrier_ok(dev))
br_stp_enable_port(p);
Expand Down

0 comments on commit 133747e

Please sign in to comment.